From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51523@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca
Subject: bug#51523: 29.0.50; gnus-mime-view-part-externally very slow
Date: Wed, 03 Nov 2021 10:45:35 +0000 [thread overview]
Message-ID: <11d5fecb444b249c7dd2@heytings.org> (raw)
In-Reply-To: <83sfwek2wu.fsf@gnu.org>
>> I attach an improved version of file-has-changed-p. Following Eli's
>> suggestion, it records the file size together with its timestamp.
>
> What about expand-file-name or file-truename? That problem still exists
> in this new patch, AFAICT.
>
I don't know what I should do here. Both Stefan and Lars think (IIUC)
that it's okay to use the filename as is. I tend to agree with them;
after all, the filename is only used as a key in the hash table, and
file-attributes finds the "right" file anyway.
Using expand-file-name or file-truename also makes that function much
slower: (benchmark-run 100000 (file-has-changed-p "~/.profile")) takes (on
my computer) 2 seconds in its current version, 3 seconds with
expand-file-name, and... 10 seconds with file-truename.
next prev parent reply other threads:[~2021-11-03 10:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 4:11 bug#51523: 29.0.50; gnus-mime-view-part-externally very slow Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 15:27 ` Lars Ingebrigtsen
2021-10-31 21:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 23:41 ` Gregory Heytings
2021-11-01 0:01 ` Lars Ingebrigtsen
2021-11-01 0:11 ` Gregory Heytings
2021-11-01 0:15 ` Lars Ingebrigtsen
2021-11-01 2:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-01 13:38 ` Lars Ingebrigtsen
2021-11-01 0:17 ` Gregory Heytings
2021-11-01 0:21 ` Lars Ingebrigtsen
2021-11-01 0:55 ` Gregory Heytings
2021-11-01 1:24 ` Gregory Heytings
2021-11-01 1:26 ` Gregory Heytings
[not found] ` <6abcac838bb94542451d@heytings.org>
2021-11-01 9:28 ` Gregory Heytings
[not found] ` <6abcac838bb83b0904d7@heytings.org>
[not found] ` <6abcac838bad7cded4c5@heytings.org>
2021-11-01 12:26 ` Gregory Heytings
2021-11-01 13:52 ` Lars Ingebrigtsen
2021-11-01 15:00 ` Eli Zaretskii
2021-11-01 15:20 ` Gregory Heytings
2021-11-01 15:23 ` Lars Ingebrigtsen
2021-11-01 16:46 ` Eli Zaretskii
2021-11-01 16:59 ` Lars Ingebrigtsen
2021-11-01 17:03 ` Eli Zaretskii
2021-11-01 17:15 ` Eli Zaretskii
2021-11-01 17:19 ` Lars Ingebrigtsen
2021-11-01 17:21 ` Eli Zaretskii
2021-11-01 17:23 ` Lars Ingebrigtsen
2021-11-01 17:28 ` Eli Zaretskii
2021-11-01 17:34 ` Lars Ingebrigtsen
2021-11-01 18:17 ` Eli Zaretskii
2021-11-01 21:14 ` Gregory Heytings
2021-11-02 14:50 ` Lars Ingebrigtsen
2021-11-02 15:12 ` Eli Zaretskii
2021-11-03 10:45 ` Gregory Heytings [this message]
2021-11-03 12:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-03 12:57 ` Gregory Heytings
2021-11-03 13:17 ` Eli Zaretskii
2021-11-03 13:27 ` Gregory Heytings
2021-11-03 13:53 ` Eli Zaretskii
2021-11-03 14:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-03 14:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-03 15:20 ` Gregory Heytings
2021-11-03 18:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-03 13:06 ` Eli Zaretskii
2021-11-01 0:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11d5fecb444b249c7dd2@heytings.org \
--to=gregory@heytings.org \
--cc=51523@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).