From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#51523: 29.0.50; gnus-mime-view-part-externally very slow Date: Wed, 03 Nov 2021 10:45:35 +0000 Message-ID: <11d5fecb444b249c7dd2@heytings.org> References: <87v91dmcyz.fsf@gnus.org> <7b7f5641fcf9629c6074@heytings.org> <875ytcwxp7.fsf@gnus.org> <6abcac838b0dd46d94cf@heytings.org> <87sfwgvi73.fsf@gnus.org> <6abcac838bc0f53a0f78@heytings.org> <6abcac838bb83b0904d7@heytings.org> <6abcac838b7f89ee4e21@heytings.org> <831r3zncow.fsf@gnu.org> <6abcac838b521de77925@heytings.org> <83zgqnlt7t.fsf@gnu.org> <87y267revf.fsf@gnus.org> <83v91blrux.fsf@gnu.org> <87o873rdyx.fsf@gnus.org> <83r1bzlrkw.fsf@gnu.org> <87bl33rdrv.fsf@gnus.org> <83mtmnlr93.fsf@gnu.org> <87wnlrpyok.fsf@gnus.org> <6abcac838b9fc735488f@heytings.org> <83sfwek2wu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51523@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 03 11:47:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miDoA-0008z3-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 11:47:54 +0100 Original-Received: from localhost ([::1]:59026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miDo9-0001K9-T5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 06:47:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miDmM-0008DX-Lx for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 06:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miDmM-0006BH-Du for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 06:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miDmM-0001xi-Bg for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 06:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51523-submit@debbugs.gnu.org id=B51523.16359363397480 (code B ref 51523); Wed, 03 Nov 2021 10:46:02 +0000 Original-Received: (at 51523) by debbugs.gnu.org; 3 Nov 2021 10:45:39 +0000 Original-Received: from localhost ([127.0.0.1]:39159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miDlz-0001wa-9b for submit@debbugs.gnu.org; Wed, 03 Nov 2021 06:45:39 -0400 Original-Received: from heytings.org ([95.142.160.155]:47042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miDlx-0001wO-5z for 51523@debbugs.gnu.org; Wed, 03 Nov 2021 06:45:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1635936335; bh=g5JOD3l+JfEcCmsMd8QlH0pCT11g3M9JwJGDNeXhplc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Baa8Lz+oUwW2XjCeX/K5K5/jlf/QJEweyVvw0e4lHTWWfMKkWCGLNxLnGKBigXhZ3 zSOYZbweb6iKbZOl7z+ntyY1632Qc+UcRDD54l4IM/alG/BibLF5WrjYcl0xXVoFhu Sk1cBbT6v7cEIvBTsGANhWPpePq2r6x6upVLkdT6Loym7wWxCsvfFwfnh1PoSTqxDe XwDgJfgHd/q9GS8k1UEtHwVns6uIWjW6stEN4JrLwWzpNX+DtUeoKM3stsM8Xw2/Hj UwxdmsQgKaK50lrbrfzGXdxxyJ2x0sfDx0xRAwI2EA6TADyV201msgIMYJM2D8uRGu vve6ImPZKJHEw== In-Reply-To: <83sfwek2wu.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218855 Archived-At: >> I attach an improved version of file-has-changed-p. Following Eli's >> suggestion, it records the file size together with its timestamp. > > What about expand-file-name or file-truename? That problem still exists > in this new patch, AFAICT. > I don't know what I should do here. Both Stefan and Lars think (IIUC) that it's okay to use the filename as is. I tend to agree with them; after all, the filename is only used as a key in the hash table, and file-attributes finds the "right" file anyway. Using expand-file-name or file-truename also makes that function much slower: (benchmark-run 100000 (file-has-changed-p "~/.profile")) takes (on my computer) 2 seconds in its current version, 3 seconds with expand-file-name, and... 10 seconds with file-truename.