From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Cyril Arnould <cyril.arnould@outlook.com>
Cc: Reto Zimmermann <reto@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
"63251@debbugs.gnu.org" <63251@debbugs.gnu.org>
Subject: bug#63251: 28.2; vhdl-mode contribution
Date: Sun, 7 May 2023 10:17:03 +0200 [thread overview]
Message-ID: <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> (raw)
In-Reply-To: <AS4PR10MB611055A0494DA22FCA2F073CE3739@AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM>
The vhdl-mode maintainers need to look at your patch more closely; I just have some minor remarks.
7 maj 2023 kl. 00.11 skrev Cyril Arnould <cyril.arnould@outlook.com>:
> - I've added TYPE to the vhdl-compiler definition with the
> appropriate choices for Info/Warning/Error and the dotted
> pair. I'm not sure if sexp was the correct choice for the
> dotted pair, is there a better alternative?
There is (cons ...) which would be more precise, see the manual.
The new doc string says that a TYPE of 2 is allowed but the type spec doesn't allow it.
Either allow both 2 and nil or change the docs to only mention one of them.
> - I added another entry to the backwards compatibility code, all
> it took was a slight modification of the entry before
> that.
That's fine, but I'd be a bit more careful with the destructive in-place changes and quoted list constants. (Think of what happens if later code performs an in-place change of that nil you added.)
This isn't performance-critical-code, we can afford consing here.
next prev parent reply other threads:[~2023-05-07 8:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 19:40 bug#63251: 28.2; vhdl-mode contribution Cyril Arnould
2023-05-04 5:16 ` Eli Zaretskii
2023-05-04 13:56 ` Reto Zimmermann
2023-05-05 5:47 ` Eli Zaretskii
2023-05-06 9:22 ` Mattias Engdegård
2023-05-06 12:53 ` bug#63251: AW: " Cyril Arnould
2023-05-06 22:11 ` Cyril Arnould
2023-05-07 8:17 ` Mattias Engdegård [this message]
2023-05-07 15:40 ` Cyril Arnould
2023-05-07 16:22 ` Mattias Engdegård
2023-05-07 17:48 ` bug#63251: AW: " Cyril Arnould
2023-05-07 17:53 ` Mattias Engdegård
2023-05-07 18:56 ` bug#63251: AW: " Cyril Arnould
2023-05-08 8:15 ` Mattias Engdegård
2023-05-09 16:16 ` bug#63251: AW: " Cyril Arnould
2023-05-09 16:41 ` Mattias Engdegård
2023-05-09 17:11 ` bug#63251: AW: " Cyril Arnould
2023-05-09 17:28 ` Mattias Engdegård
2023-05-07 15:56 ` bug#63251: AW: " Cyril Arnould
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=63251@debbugs.gnu.org \
--cc=cyril.arnould@outlook.com \
--cc=eliz@gnu.org \
--cc=reto@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).