unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Cyril Arnould <cyril.arnould@outlook.com>
Cc: Reto Zimmermann <reto@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
	"63251@debbugs.gnu.org" <63251@debbugs.gnu.org>
Subject: bug#63251: 28.2; vhdl-mode contribution
Date: Tue, 9 May 2023 18:41:39 +0200	[thread overview]
Message-ID: <A42BCCBA-2DCB-4AA7-B4A8-9F118A468F61@gmail.com> (raw)
In-Reply-To: <AS4PR10MB6110C3582AE98538509CD56FE3769@AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM>

9 maj 2023 kl. 18.16 skrev Cyril Arnould <cyril.arnould@outlook.com>:

> By defining the error message type to be nil rather than 2, we
> can forego the backwards compatibility code.
> <fix-vhdl-compiler-customization-4.patch>

Looks fine (although I had hoped to establish a precedent for less mutation in the updating code...).

Actually there is another argument to include updating code: subsequent changes will likely rely on existing values to conform strictly to the previous type and will likely botch any updating of values that don't.

For example, if yet another value is added to the entry, then it cannot just be appended to each entry because that entry might be too short because of the incomplete previous update.






  reply	other threads:[~2023-05-09 16:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 19:40 bug#63251: 28.2; vhdl-mode contribution Cyril Arnould
2023-05-04  5:16 ` Eli Zaretskii
2023-05-04 13:56   ` Reto Zimmermann
2023-05-05  5:47     ` Eli Zaretskii
2023-05-06  9:22 ` Mattias Engdegård
2023-05-06 12:53   ` bug#63251: AW: " Cyril Arnould
2023-05-06 22:11     ` Cyril Arnould
2023-05-07  8:17       ` Mattias Engdegård
2023-05-07 15:40         ` bug#63251: AW: " Cyril Arnould
2023-05-07 16:22           ` Mattias Engdegård
2023-05-07 17:48             ` bug#63251: AW: " Cyril Arnould
2023-05-07 17:53               ` Mattias Engdegård
2023-05-07 18:56                 ` bug#63251: AW: " Cyril Arnould
2023-05-08  8:15                   ` Mattias Engdegård
2023-05-09 16:16                     ` bug#63251: AW: " Cyril Arnould
2023-05-09 16:41                       ` Mattias Engdegård [this message]
2023-05-09 17:11                         ` Cyril Arnould
2023-05-09 17:28                           ` Mattias Engdegård
2023-05-07 15:56         ` bug#63251: AW: " Cyril Arnould

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A42BCCBA-2DCB-4AA7-B4A8-9F118A468F61@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=63251@debbugs.gnu.org \
    --cc=cyril.arnould@outlook.com \
    --cc=eliz@gnu.org \
    --cc=reto@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).