From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#63251: 28.2; vhdl-mode contribution Date: Sun, 7 May 2023 10:17:03 +0200 Message-ID: <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11684"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> To: Cyril Arnould Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 10:18:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvZb2-0002ph-82 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 10:18:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvZan-00084H-SG; Sun, 07 May 2023 04:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvZam-000846-7c for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 04:18:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvZal-00086M-Tx for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 04:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvZak-0002SO-NE for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 04:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 08:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63251 X-GNU-PR-Package: emacs Original-Received: via spool by 63251-submit@debbugs.gnu.org id=B63251.16834474349374 (code B ref 63251); Sun, 07 May 2023 08:18:02 +0000 Original-Received: (at 63251) by debbugs.gnu.org; 7 May 2023 08:17:14 +0000 Original-Received: from localhost ([127.0.0.1]:36340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvZZy-0002R7-9k for submit@debbugs.gnu.org; Sun, 07 May 2023 04:17:14 -0400 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:50362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvZZv-0002Qo-B0 for 63251@debbugs.gnu.org; Sun, 07 May 2023 04:17:11 -0400 Original-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f14e499ffcso2024788e87.0 for <63251@debbugs.gnu.org>; Sun, 07 May 2023 01:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683447425; x=1686039425; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=YBTjnRC9OvMfLOtgvTwfwXaneuSd1UMRKvol3Thpm0k=; b=CIAVRPL9oEIwepYJgLEmcLo7RV2BEdfgZQjXlqx21xgv5AjzT9cs/th38fRKZKMKfc rdHTwLFQrv9OAComzOI7d/k3lkb3AExPEpyqjHyWgMsnEaWCFUPFtsxOob9I9IMmz4kS jrlYbVi5+oLVl/GkHu35eCca5cMijci7UZgsnmUFkOtRAM72mNYrcUHWgDD+3iH5mPs1 4uP/jSyfwsCbmDaWKhloGeKcgWmNPjhLqMPBgDsQlzx9t7TIyjaXFMmrGG93N/aCfdxk lgqQi//y1l7cjrhiXV2OYwIHGhKeRJkmlZr6GzC65Cpl8NJwUGpfp93wW3QIDFYErWf8 gOwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683447425; x=1686039425; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YBTjnRC9OvMfLOtgvTwfwXaneuSd1UMRKvol3Thpm0k=; b=NWEa18I2hiNj4Jv2n3O35btE6IJdYpj/vlAUQF5aNhN9CP68WrsDQCfNmxxjM7ambJ zFRcPCTHFcU4Y+8J55lm61nfdHqS+tL9nlNoKmT6hHMMJaLuN1W3wTPloM+iHEtIDyW5 oW+SDa+KCRK+a9yscvwj4FqY3wVek1vcp5RBxJFfhjgaegRPge84lo2rxjL+PoKR+DfP Z2wSclyGKJ6a/eSVMyWETeT2H17igYCHa15DAbheSpWLjY9q4SZmBm/pFdnnY/LEnx4b 0Pd3FKdQ8djSMGj1n+ugrKqQoT1yf5TRH7ergIEDcLdUebuJdJ77XHlC3ex4LxgFdsip dnEQ== X-Gm-Message-State: AC+VfDw/uq11xRpqTfRHrLHb96N2g5+O3fMDUHNy76wgd3WAA8g+Gkqs tgNjGGbsC1/An2ktp0x989c= X-Google-Smtp-Source: ACHHUZ6y+jiPO3ooc0lbnWpyAPRatYVr68tQ1FnDowIQVK45Ri8fXDryj1fJLgDrJLDcwp77pkf4lQ== X-Received: by 2002:ac2:5d23:0:b0:4db:ebb3:b529 with SMTP id i3-20020ac25d23000000b004dbebb3b529mr1694944lfb.46.1683447424836; Sun, 07 May 2023 01:17:04 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id c8-20020a05651221a800b004edafe3f8dbsm909209lft.11.2023.05.07.01.17.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 May 2023 01:17:04 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261239 Archived-At: The vhdl-mode maintainers need to look at your patch more closely; I = just have some minor remarks. 7 maj 2023 kl. 00.11 skrev Cyril Arnould : > - I've added TYPE to the vhdl-compiler definition with the > appropriate choices for Info/Warning/Error and the dotted > pair. I'm not sure if sexp was the correct choice for the > dotted pair, is there a better alternative? There is (cons ...) which would be more precise, see the manual. The new doc string says that a TYPE of 2 is allowed but the type spec = doesn't allow it. Either allow both 2 and nil or change the docs to only mention one of = them. > - I added another entry to the backwards compatibility code, all > it took was a slight modification of the entry before > that. That's fine, but I'd be a bit more careful with the destructive in-place = changes and quoted list constants. (Think of what happens if later code = performs an in-place change of that nil you added.) This isn't performance-critical-code, we can afford consing here.