bug#50256: thing-at-mouse

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

 > That's orthogonal.  (And it seems to issue the warning in an unrelated
 > case, handled by the 'else' clause?)

Which case?

 > We should first decide how to
 > support the context menus with this stuff, and then we can talk how to
 > find code out there which makes similar assumptions.  (But if there is
 > such code out there, how was it working till now?)

Maybe I have not been making myself clear.  What I would apply is the
attached (modulo any errors it contains): No change in behavior, just a
warning in the doc-string and suspicious calls.

martin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pos-visible-in-window-p.diff --]
[-- Type: text/x-patch; name="pos-visible-in-window-p.diff", Size: 1445 bytes --]

diff --git a/src/window.c b/src/window.c
index cb8fe5fcdb..a7ad4d5599 100644
--- a/src/window.c
+++ b/src/window.c
@@ -2172,6 +2172,10 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p,
 first.  POS defaults to point in WINDOW; WINDOW defaults to the
 selected window.

+Do not pass nil as POS unless you are sure that WINDOW displays the
+current buffer.  This function will emit a warning when POS is neither a
+marker, a number or t and WINDOW does not display the current buffer.
+
 If POS is visible, return t if PARTIALLY is nil; if PARTIALLY is non-nil,
 the return value is a list of 2 or 6 elements (X Y [RTOP RBOT ROWH VPOS]),
 where X and Y are the pixel coordinates relative to the top left corner
@@ -2199,10 +2203,16 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p,
     posint = -1;
   else if (!NILP (pos))
     posint = fix_position (pos);
-  else if (w == XWINDOW (selected_window))
-    posint = PT;
   else
-    posint = marker_position (w->pointm);
+    {
+      if (XBUFFER (w->contents) != current_buffer)
+	message ("`pos-visible-in-window' called with POS nil but WINDOW's buffer is not current");
+
+      if (w == XWINDOW (selected_window))
+	posint = PT;
+      else
+	posint = marker_position (w->pointm);
+    }

   /* If position is above window start or outside buffer boundaries,
      or if window start is out of range, position is not visible.  */