bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'

bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'

[Drew Adams]

1. The doc strings of `multi-isearch-files(-regexp)' need to say that
each of the FILES elements must be an absolute file name. I was trying
to make it work with relative names, and I wasted a lot of time
debugging. It was only when the debugger finally got to comparing
`buffer-file-name' with the FILES element that I saw the problem.
 
2. Why not let these functions accept either absolute or relative file
names?  If relative, they should be interpreted relative to
`default-directory'.
 
3. Similarly, for `multi-isearch-buffers(-regexp)': 
 
a. The doc strings need to say explicitly that the BUFFERS must be
live buffers, not their names.
 
b. Why should the BUFFERS need to be buffers - why not also allow
buffer names?
 
The code is unnecessarily restrictive/brittle.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'

[Juri Linkov]

> 1. The doc strings of `multi-isearch-files(-regexp)' need to say that
> each of the FILES elements must be an absolute file name. I was trying
> to make it work with relative names, and I wasted a lot of time
> debugging. It was only when the debugger finally got to comparing
> `buffer-file-name' with the FILES element that I saw the problem.
>
> 2. Why not let these functions accept either absolute or relative file
> names?  If relative, they should be interpreted relative to
> `default-directory'.

Using relative file names will make these functions unreliable and
non-deterministic.  For instance, when you create a list of file names
in subdirectories relative to the current directory '("./dir1/file1"
"./dir2/file2") and multi-isearch visits file1 in the first subdir dir1,
then going to the next file "./dir2/file2" relative to the base dir
will fail in dir1.

However, we could convert relative file names to internal absolute
file names before starting multi-file Isearch.  So you will be able
to specify file names relative to the default directory where
multi-file Isearch was started.

> 3. Similarly, for `multi-isearch-buffers(-regexp)':
>
> a. The doc strings need to say explicitly that the BUFFERS must be
> live buffers, not their names.
>
> b. Why should the BUFFERS need to be buffers - why not also allow
> buffer names?
>
> The code is unnecessarily restrictive/brittle.

Similarly, we could convert buffer names to internal live buffers
before starting multi-buffer Isearch.

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'

[Drew Adams]

> However, we could convert relative file names to internal absolute
> file names before starting multi-file Isearch.  So you will be able
> to specify file names relative to the default directory where
> multi-file Isearch was started.

That was what I was thinking.

> > 3. Similarly, for `multi-isearch-buffers(-regexp)':
> >
> > a. The doc strings need to say explicitly that the BUFFERS must be
> > live buffers, not their names.
> >
> > b. Why should the BUFFERS need to be buffers - why not also allow
> > buffer names?
> >
> > The code is unnecessarily restrictive/brittle.
> 
> Similarly, we could convert buffer names to internal live buffers
> before starting multi-buffer Isearch.

Why not? That's pretty standard. Let the function do the work of calling
`get-buffer'.

bug#4727: marked as done (23.1; `multi-isearch-(files|buffers)(-regexp)')

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Your message dated Mon, 30 Nov 2009 22:28:12 +0200
with message-id <87aay3kbad.fsf@mail.jurta.org>
and subject line Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'
has caused the Emacs bug report #4727,
regarding 23.1; `multi-isearch-(files|buffers)(-regexp)'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4727: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4727
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3815 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <bug-gnu-emacs@gnu.org>
Subject: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Wed, 14 Oct 2009 17:27:56 -0700
Message-ID: <7B1FFB82981740F6AC4C32F1918C2E04@us.oracle.com>

1. The doc strings of `multi-isearch-files(-regexp)' need to say that
each of the FILES elements must be an absolute file name. I was trying
to make it work with relative names, and I wasted a lot of time
debugging. It was only when the debugger finally got to comparing
`buffer-file-name' with the FILES element that I saw the problem.
 
2. Why not let these functions accept either absolute or relative file
names?  If relative, they should be interpreted relative to
`default-directory'.
 
3. Similarly, for `multi-isearch-buffers(-regexp)': 
 
a. The doc strings need to say explicitly that the BUFFERS must be
live buffers, not their names.
 
b. Why should the BUFFERS need to be buffers - why not also allow
buffer names?
 
The code is unnecessarily restrictive/brittle.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 




[-- Attachment #3: Type: message/rfc822, Size: 2151 bytes --]

From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 4727-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Mon, 30 Nov 2009 22:28:12 +0200
Message-ID: <87aay3kbad.fsf@mail.jurta.org>

>> However, we could convert relative file names to internal absolute
>> file names before starting multi-file Isearch.  So you will be able
>> to specify file names relative to the default directory where
>> multi-file Isearch was started.
>
> That was what I was thinking.

Thanks for the idea.  Implemented.

>> Similarly, we could convert buffer names to internal live buffers
>> before starting multi-buffer Isearch.
>
> Why not? That's pretty standard. Let the function do the work of calling
> `get-buffer'.

This is implemented as well.

-- 
Juri Linkov
http://www.jurta.org/emacs/