From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4727: marked as done (23.1; `multi-isearch-(files|buffers)(-regexp)') Date: Mon, 30 Nov 2009 20:35:04 +0000 Message-ID: References: <87aay3kbad.fsf@mail.jurta.org> <7B1FFB82981740F6AC4C32F1918C2E04@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1259613304-23310-0" X-Trace: ger.gmane.org 1259614072 19363 80.91.229.12 (30 Nov 2009 20:47:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2009 20:47:52 +0000 (UTC) To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 21:47:45 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NFD9p-0006fz-S4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 21:47:42 +0100 Original-Received: from localhost ([127.0.0.1]:52138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFD9p-0000El-Am for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 15:47:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFD9f-000095-5p for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:47:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFD9a-00005d-H9 for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:47:30 -0500 Original-Received: from [199.232.76.173] (port=43582 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFD9a-00005U-9l for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:47:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35569) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFD9Z-0001xw-OO for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:47:26 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUKlN3D024515; Mon, 30 Nov 2009 12:47:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAUKZ4oG023342; Mon, 30 Nov 2009 12:35:04 -0800 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4727 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33085 Archived-At: This is a multi-part message in MIME format... ------------=_1259613304-23310-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 30 Nov 2009 22:28:12 +0200 with message-id <87aay3kbad.fsf@mail.jurta.org> and subject line Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp= )' has caused the Emacs bug report #4727, regarding 23.1; `multi-isearch-(files|buffers)(-regexp)' to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4727: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4727 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1259613304-23310-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 15 Oct 2009 00:29:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9F0TV2G003056 for ; Wed, 14 Oct 2009 17:29:32 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyEDi-0004dK-N4 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 20:29:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyEDd-0004cr-MF for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 20:29:29 -0400 Received: from [199.232.76.173] (port=56900 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyEDd-0004co-H9 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 20:29:25 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:48787) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyEDd-0002GP-2v for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 20:29:25 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9F0TDUK032257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Oct 2009 00:29:14 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9EAgHU1018776 for ; Thu, 15 Oct 2009 00:29:17 GMT Received: from abhmt008.oracle.com by acsmt354.oracle.com with ESMTP id 20413185021255566468; Wed, 14 Oct 2009 17:27:48 -0700 Received: from dradamslap1 (/141.144.160.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Oct 2009 17:27:47 -0700 From: "Drew Adams" To: Subject: 23.1; `multi-isearch-(files|buffers)(-regexp)' Date: Wed, 14 Oct 2009 17:27:56 -0700 Message-ID: <7B1FFB82981740F6AC4C32F1918C2E04@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcpNLle2iF5LgG5nQzGapg5IOjHtmQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4AD66CDC.00AB:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) 1. The doc strings of `multi-isearch-files(-regexp)' need to say that each of the FILES elements must be an absolute file name. I was trying to make it work with relative names, and I wasted a lot of time debugging. It was only when the debugger finally got to comparing `buffer-file-name' with the FILES element that I saw the problem. 2. Why not let these functions accept either absolute or relative file names? If relative, they should be interpreted relative to `default-directory'. 3. Similarly, for `multi-isearch-buffers(-regexp)': a. The doc strings need to say explicitly that the BUFFERS must be live buffers, not their names. b. Why should the BUFFERS need to be buffers - why not also allow buffer names? The code is unnecessarily restrictive/brittle. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1259613304-23310-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4727-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 20:28:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUKSlCm022821 for <4727-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 12:28:49 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx1.starman.ee (Postfix) with ESMTP id EF80C3F413D; Mon, 30 Nov 2009 22:28:41 +0200 (EET) From: Juri Linkov To: "Drew Adams" Cc: 4727-done@emacsbugs.donarmstrong.com Subject: Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)' Organization: JURTA References: <7B1FFB82981740F6AC4C32F1918C2E04@us.oracle.com> <87fx9kz5x5.fsf@mail.jurta.org> <083F366AB17D4E52AC846BCFEF20B28F@us.oracle.com> Date: Mon, 30 Nov 2009 22:28:12 +0200 In-Reply-To: <083F366AB17D4E52AC846BCFEF20B28F@us.oracle.com> (Drew Adams's message of "Thu, 15 Oct 2009 15:52:18 -0700") Message-ID: <87aay3kbad.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> However, we could convert relative file names to internal absolute >> file names before starting multi-file Isearch. So you will be able >> to specify file names relative to the default directory where >> multi-file Isearch was started. > > That was what I was thinking. Thanks for the idea. Implemented. >> Similarly, we could convert buffer names to internal live buffers >> before starting multi-buffer Isearch. > > Why not? That's pretty standard. Let the function do the work of calling > `get-buffer'. This is implemented as well. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1259613304-23310-0--