* bug#38014: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message
@ 2019-11-01 2:59 lin.sun
2020-01-19 2:31 ` bug#38014: Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
2020-01-19 2:36 ` bug#38014: Recall: " lin.sun
0 siblings, 2 replies; 3+ messages in thread
From: lin.sun @ 2019-11-01 2:59 UTC (permalink / raw)
To: 38014
[PATCH] * makefile-edit.el: regexp-quote the param in
makefile-move-to-macro.
Fix the error message from `makefile-move-to-macro' when there is '$'
or '\\' in param for re-search-forward, with `(global-ede-mode t)' and
`(semantic-mode t)'. Enable ede and semantic mode, then open a
Makefile.am in which has line 'AM_LIBTMP_LIBS:=$(shell X \--libs)'
will trigger this issue.
---
lisp/cedet/ede/makefile-edit.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/cedet/ede/makefile-edit.el
b/lisp/cedet/ede/makefile-edit.el
index 7d8a44b..add1675 100644
--- a/lisp/cedet/ede/makefile-edit.el
+++ b/lisp/cedet/ede/makefile-edit.el
@@ -78,7 +78,7 @@ makefile-move-to-macro
If NEXT is non-nil, move to the next occurrence of MACRO."
(let ((oldpt (point)))
(when (not next) (goto-char (point-min)))
- (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t)
+ (if (re-search-forward (concat "^\\s-*" (regexp-quote macro)
"\\s-*[+:?]?=") nil t)
t
(goto-char oldpt)
nil)))
--
2.2.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#38014: Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message)
2019-11-01 2:59 bug#38014: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message lin.sun
@ 2020-01-19 2:31 ` lin.sun
2020-01-19 2:36 ` bug#38014: Recall: " lin.sun
1 sibling, 0 replies; 3+ messages in thread
From: lin.sun @ 2020-01-19 2:31 UTC (permalink / raw)
To: 38014
Close this ticket please.
The original issue is fixed in #39094, both emacs 27.50 and emacs master.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#38014: Recall: bug#38014: Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message)
2019-11-01 2:59 bug#38014: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message lin.sun
2020-01-19 2:31 ` bug#38014: Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
@ 2020-01-19 2:36 ` lin.sun
1 sibling, 0 replies; 3+ messages in thread
From: lin.sun @ 2020-01-19 2:36 UTC (permalink / raw)
To: 38014
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
lin.sun@zoom.us would like to recall the message, "bug#38014:
Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param
in makefile-move-to-macro to avoid error message)".
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 1809 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-19 2:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 2:59 bug#38014: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message lin.sun
2020-01-19 2:31 ` bug#38014: Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
2020-01-19 2:36 ` bug#38014: Recall: " lin.sun
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).