From: <lin.sun@zoom.us>
To: 38014@debbugs.gnu.org
Subject: bug#38014: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message
Date: Fri, 1 Nov 2019 10:59:44 +0800 [thread overview]
Message-ID: <001001d59060$6b8f6f00$42ae4d00$@zoom.us> (raw)
[PATCH] * makefile-edit.el: regexp-quote the param in
makefile-move-to-macro.
Fix the error message from `makefile-move-to-macro' when there is '$'
or '\\' in param for re-search-forward, with `(global-ede-mode t)' and
`(semantic-mode t)'. Enable ede and semantic mode, then open a
Makefile.am in which has line 'AM_LIBTMP_LIBS:=$(shell X \--libs)'
will trigger this issue.
---
lisp/cedet/ede/makefile-edit.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/cedet/ede/makefile-edit.el
b/lisp/cedet/ede/makefile-edit.el
index 7d8a44b..add1675 100644
--- a/lisp/cedet/ede/makefile-edit.el
+++ b/lisp/cedet/ede/makefile-edit.el
@@ -78,7 +78,7 @@ makefile-move-to-macro
If NEXT is non-nil, move to the next occurrence of MACRO."
(let ((oldpt (point)))
(when (not next) (goto-char (point-min)))
- (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t)
+ (if (re-search-forward (concat "^\\s-*" (regexp-quote macro)
"\\s-*[+:?]?=") nil t)
t
(goto-char oldpt)
nil)))
--
2.2.0
next reply other threads:[~2019-11-01 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 2:59 lin.sun [this message]
2020-01-19 2:31 ` bug#38014: Acknowledgement (26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
2020-01-19 2:36 ` bug#38014: Recall: " lin.sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001001d59060$6b8f6f00$42ae4d00$@zoom.us' \
--to=lin.sun@zoom.us \
--cc=38014@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).