emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Eric Schulte" <schulte.eric@gmail.com>
To: Benjamin Andresen <benny@in-ulm.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: sreen : unable to run org-babel-screen-test
Date: Mon, 30 Nov 2009 07:26:07 -0700	[thread overview]
Message-ID: <yn4y6loytq8.fsf@gmail.com> (raw)
In-Reply-To: <871vjg9qaw.fsf@in-ulm.de> (Benjamin Andresen's message of "Mon, 30 Nov 2009 12:59:19 +0100")

Hi Benny,

We should have caught this usage when we changed the variable passing
behavior in org-babel.  Thanks for the patch, it is now applied.

Best -- Eric

Benjamin Andresen <benny@in-ulm.de> writes:

> Hey,
>
> Benjamin Andresen <benny@in-ulm.de> writes:
>
>> I will have a look and report back with my findings!
>
> I was relying on a variable which used to contain the value it needed,
> but doesn't do any more. It was a foolish shortcut and now it uses the
> official route by processing the parameters that are passed to it.
>
> As I don't have access to the official org-mode git repo, can someone
> please apply this patch for me?
>
> br,
> benny
>
> P.S. I'm not committing this patch to the org-babel repo, out of fear of
> merge issues later on. I guess this route is better? Thanks!
>
> diff --git a/contrib/babel/lisp/langs/org-babel-screen.el b/contrib/babel/lisp/langs/org-babel-screen.el
> index efeab23..1529ac0 100644
> --- a/contrib/babel/lisp/langs/org-babel-screen.el
> +++ b/contrib/babel/lisp/langs/org-babel-screen.el
> @@ -55,7 +55,9 @@ In case you want to use a different screen than one selected by your $PATH")
>  \"default\" session is be used when none is specified."
>    (message "Sending source code block to interactive terminal session...")
>    (save-window-excursion
> -    (let ((socket (org-babel-screen-session-socketname session)))
> +    (let* ((processed-params (org-babel-process-params params))
> +           (session (first processed-params))
> +           (socket (org-babel-screen-session-socketname session)))
>        (unless socket (org-babel-prep-session:screen session params))
>        (org-babel-screen-session-execute-string session body))))
>  
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2009-11-30 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30  8:13 [babel] sreen : unable to run org-babel-screen-test bluedian
2009-11-30 11:32 ` Benjamin Andresen
2009-11-30 11:59   ` Benjamin Andresen
2009-11-30 14:26     ` Eric Schulte [this message]
2009-12-01  7:50       ` bluedian
2009-12-01 12:20         ` Benjamin Andresen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yn4y6loytq8.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=benny@in-ulm.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).