From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: Re: sreen : unable to run org-babel-screen-test Date: Mon, 30 Nov 2009 07:26:07 -0700 Message-ID: References: <87638s9ris.fsf@in-ulm.de> <871vjg9qaw.fsf@in-ulm.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF7Cd-0001Rj-Bm for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:26:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF7CY-0001Qd-Ob for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:26:11 -0500 Received: from [199.232.76.173] (port=48894 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF7CY-0001Qa-MD for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:26:06 -0500 Received: from mail-pz0-f181.google.com ([209.85.222.181]:33258) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF7CY-0005E6-FT for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:26:06 -0500 Received: by pzk11 with SMTP id 11so2268698pzk.14 for ; Mon, 30 Nov 2009 06:26:05 -0800 (PST) In-Reply-To: <871vjg9qaw.fsf@in-ulm.de> (Benjamin Andresen's message of "Mon, 30 Nov 2009 12:59:19 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Benjamin Andresen Cc: emacs-orgmode@gnu.org Hi Benny, We should have caught this usage when we changed the variable passing behavior in org-babel. Thanks for the patch, it is now applied. Best -- Eric Benjamin Andresen writes: > Hey, > > Benjamin Andresen writes: > >> I will have a look and report back with my findings! > > I was relying on a variable which used to contain the value it needed, > but doesn't do any more. It was a foolish shortcut and now it uses the > official route by processing the parameters that are passed to it. > > As I don't have access to the official org-mode git repo, can someone > please apply this patch for me? > > br, > benny > > P.S. I'm not committing this patch to the org-babel repo, out of fear of > merge issues later on. I guess this route is better? Thanks! > > diff --git a/contrib/babel/lisp/langs/org-babel-screen.el b/contrib/babel/lisp/langs/org-babel-screen.el > index efeab23..1529ac0 100644 > --- a/contrib/babel/lisp/langs/org-babel-screen.el > +++ b/contrib/babel/lisp/langs/org-babel-screen.el > @@ -55,7 +55,9 @@ In case you want to use a different screen than one selected by your $PATH") > \"default\" session is be used when none is specified." > (message "Sending source code block to interactive terminal session...") > (save-window-excursion > - (let ((socket (org-babel-screen-session-socketname session))) > + (let* ((processed-params (org-babel-process-params params)) > + (session (first processed-params)) > + (socket (org-babel-screen-session-socketname session))) > (unless socket (org-babel-prep-session:screen session params)) > (org-babel-screen-session-execute-string session body)))) > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode