Bug: need to eval-when-compile org-compat [8.0.5 (8.0.5-elpaplus @ /u/kimr/elisp/emacs-24/org-plus-contrib-20130704/)]

Bug: need to eval-when-compile org-compat [8.0.5 (8.0.5-elpaplus @ /u/kimr/elisp/emacs-24/org-plus-contrib-20130704/)]

[Richard Kim]

Line 83 of org.el nees to be changed from

  (require 'org-compat)

to

  (eval-when-compile (require 'org-compat))

in order to prevent (invalid-function org-with-silent-modifications)
error when an org file is loaded and `C-x C-e h h' is hit to export to
a file.  The call stack is

  org-with-silent-modifications
  org-refresh-category-properties
  org-get-category
  org-entry-properties
  org-element-headline-parser
  org-element--current-element
  org-element--parse-elements
  org-element-parse-buffer
  org-export-filter-apply-functions
  org-export-as
  org-export-to-file
  org-html-export-to-html
  org-export-dispatch
  call-interactively(org-export-dispatch nil nil)

This occured on emacs-24 (which I compiled using latest version from
http://bzr.savannah.gnu.org/r/emacs/emacs-24/ branch as of July 6,
2013).  This is with org-plus-contrib-20130704.tar ELPA package
installed.

I can work around (invalid-function org-with-silent-modifications)
problem if I byte compile org.el again after making sure that org-compat
is loaded.  However it seems like to me that one should not have to mess
with files byte compiled as part of `M-x package-install'.  That is why
I think the one line change suggested above should be made.

Emacs  : GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10)
 of 2013-07-06 on kimr-laptop
Package: Org-mode version 8.0.5 (8.0.5-elpaplus @ /u/kimr/elisp/emacs-24/org-plus-contrib-20130704/)

Re: Bug: need to eval-when-compile org-compat [8.0.5 (8.0.5-elpaplus <at> /u/kimr/elisp/emacs-24/org-plus-contrib-20130704/)]

[Achim Gratz]

Richard Kim <emacs18 <at> gmail.com> writes:
> 
> Line 83 of org.el nees to be changed from
> 
>   (require 'org-compat)
> 
> to
> 
>   (eval-when-compile (require 'org-compat))

No, absolutely not: require does an implicit eval-and-compile.

> in order to prevent (invalid-function org-with-silent-modifications)
> error when an org file is loaded and `C-x C-e h h' is hit to export to
> a file.

This is a different problem, namely package manager getting into the game
after parts of the Org that ship with Emacs24 have already been loaded. 
This has been discussed before as well as how to workaround it.  In a
nutshell, you need to install Orgmode in an entirely fresh session.  When
you still hit this problem, then restart Emacs and (in the same session)
remove and then re-install Org.


Regards,
Achim.