emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Documentation: Equal sign incorrectly listed as disallowed in plain links
@ 2023-07-22  0:51 Tom Alexander
  2023-07-22  6:58 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Alexander @ 2023-07-22  0:51 UTC (permalink / raw)
  To: emacs-orgmode

The documentation for plain links states that PATHPLAIN is:

> A string containing non-whitespace non-bracket (()[]<>=) characters, optionally containing parenthesis-wrapped non-whitespace non-bracket substrings up to a depth of two. The string must end with either a non-punctation non-whitespace character, a forwards slash, or a parenthesis-wrapped substring.

but if we create an org-mode document with the following test content:
```
http://foo/bar=baz

http://foo/bar[baz
```

and run a M-x eval-expression (message "%s" (pp-to-string (org-element-parse-buffer)))

Then we can see that it allows the equals sign in the PATHPLAIN (output pasted below)

Link to the documentation: https://orgmode.org/worg/org-syntax.html#org6934900

Syntax tree:
```
(org-data
(:begin 1 :contents-begin 1 :contents-end 40 :end 40 :robust-begin 3 :robust-end 38 :post-blank 0 :post-affiliated 1 :path "/tmp/test/test.org" :mode org-data :CATEGORY "test" :granularity nil)
(section
  (:begin 1 :end 40 :contents-begin 1 :contents-end 40 :robust-begin 1 :robust-end 38 :post-blank 0 :post-affiliated 1 :mode first-section :granularity nil :parent #0)
  (paragraph
   (:begin 1 :end 21 :contents-begin 1 :contents-end 20 :post-blank 1 :post-affiliated 1 :mode top-comment :granularity nil :parent #1)
   (link
    (:type "http" :path "//foo/bar=baz" :format plain :raw-link "http://foo/bar=baz" :application nil :search-option nil :begin 1 :end 19 :contents-begin nil :contents-end nil :post-blank 0 :parent #2))
   #("\n" 0 1
     (:parent #2)))
  (paragraph
   (:begin 21 :end 40 :contents-begin 21 :contents-end 40 :post-blank 0 :post-affiliated 21 :mode nil :granularity nil :parent #1)
   (link
    (:type "http" :path "//foo/bar" :format plain :raw-link "http://foo/bar" :application nil :search-option nil :begin 21 :end 35 :contents-begin nil :contents-end nil :post-blank 0 :parent #2))
   #("[baz\n" 0 5
     (:parent #2)))))
```



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Documentation: Equal sign incorrectly listed as disallowed in plain links
  2023-07-22  0:51 Documentation: Equal sign incorrectly listed as disallowed in plain links Tom Alexander
@ 2023-07-22  6:58 ` Ihor Radchenko
  2023-07-22  7:22   ` Tom Alexander
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2023-07-22  6:58 UTC (permalink / raw)
  To: Tom Alexander; +Cc: emacs-orgmode

"Tom Alexander" <tom@fizz.buzz> writes:

> The documentation for plain links states that PATHPLAIN is:
>
>> A string containing non-whitespace non-bracket (()[]<>=) characters, optionally containing parenthesis-wrapped non-whitespace non-bracket substrings up to a depth of two. The string must end with either a non-punctation non-whitespace character, a forwards slash, or a parenthesis-wrapped substring.
>
> but if we create an org-mode document with the following test content:
> ```
> http://foo/bar=baz

As you can see from the sentence, PATHPLAIN must be "non-whitespace"
"non-bracket". "=" is just a messed up verbatim markup marker.

Fixed, on master.
https://git.sr.ht/~bzg/worg/commit/85ef10ed

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Documentation: Equal sign incorrectly listed as disallowed in plain links
  2023-07-22  6:58 ` Ihor Radchenko
@ 2023-07-22  7:22   ` Tom Alexander
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Alexander @ 2023-07-22  7:22 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Thanks for fixing all the documentation issues I submitted today!

On Sat, Jul 22, 2023, at 2:58 AM, Ihor Radchenko wrote:
> "Tom Alexander" <tom@fizz.buzz> writes:
>
>> The documentation for plain links states that PATHPLAIN is:
>>
>>> A string containing non-whitespace non-bracket (()[]<>=) characters, optionally containing parenthesis-wrapped non-whitespace non-bracket substrings up to a depth of two. The string must end with either a non-punctation non-whitespace character, a forwards slash, or a parenthesis-wrapped substring.
>>
>> but if we create an org-mode document with the following test content:
>> ```
>> http://foo/bar=baz
>
> As you can see from the sentence, PATHPLAIN must be "non-whitespace"
> "non-bracket". "=" is just a messed up verbatim markup marker.
>
> Fixed, on master.
> https://git.sr.ht/~bzg/worg/commit/85ef10ed
>
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-22  7:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-22  0:51 Documentation: Equal sign incorrectly listed as disallowed in plain links Tom Alexander
2023-07-22  6:58 ` Ihor Radchenko
2023-07-22  7:22   ` Tom Alexander

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).