Bug: Infinite loop in `org-previous-item' when there's nothing above item (patch included) [6.33trans (release_6.33f.80.gb777e3)]

Bug: Infinite loop in `org-previous-item' when there's nothing above item (patch included) [6.33trans (release_6.33f.80.gb777e3)]

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

When `org-previous-item' is called on an item with nothing above it
Orgmode enters an infinite loop. The reason is that
`org-previous-item' searches for non-empty lines by moving point up
line by line and if there is nothing above an item point gets stuck on
begin of buffer.

example.org
,----
| 
|  - Item
`----

Move point on Item, M-x org-previous-item RET and Orgmode enters the
infinite loop.

Attached patch adds a conditional clause to `org-previous-item' that
leaves the search loop if point reaches beginning of buffer.

Emacs  : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
 of 2009-11-28 on elegiac, modified by Debian
Package: Org-mode version 6.33trans (release_6.33f.80.gb777e3)


[-- Attachment #2: 0001-org-list.el-Prevent-infinite-loop-in-org-previous-it.patch --]
[-- Type: application/octet-stream, Size: 1167 bytes --]

From b777e3969372f23ed357bdd4058c1445ccfe5d38 Mon Sep 17 00:00:00 2001
From: David Maus <maus.david@gmail.com>
Date: Sat, 5 Dec 2009 21:56:34 +0100
Subject: [PATCH] org-list.el: Prevent infinite loop in `org-previous-item'

When `org-previous-item' is called on an item with nothing above it
Orgmode enters an infinite loop. The reason is that
`org-previous-item' searches for non-empty lines by moving point up
line by line and if there is nothing above an item point gets stuck on
begin of buffer.

Patch adds a conditional clause that leaves the search loop if point
reaches beginning of buffer.
---
 lisp/org-list.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/org-list.el b/lisp/org-list.el
index edd612a..56cbc42 100644
--- a/lisp/org-list.el
+++ b/lisp/org-list.el
@@ -616,7 +616,8 @@ Error if not at a plain list, or if this is the first item in the list."
 	(if (looking-at "[ \t]*$")
 	    nil
 	  (if (<= (setq ind1 (org-get-indentation)) ind)
-	      (throw 'exit t)))))
+	      (throw 'exit t)))
+	(if (bobp) (throw 'exit t))))
     (condition-case nil
 	(if (or (not (org-at-item-p))
 		(< ind1 (1- ind)))
-- 
1.6.5


[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: Infinite loop in `org-previous-item' when there's nothing above item (patch included) [6.33trans (release_6.33f.80.gb777e3)]

[Carsten Dominik]

Hi David,

I have applied your patch, thanks!

- Carsten

On Dec 5, 2009, at 10:03 PM, David Maus wrote:

>
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?   
> See
>
>     http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> When `org-previous-item' is called on an item with nothing above it
> Orgmode enters an infinite loop. The reason is that
> `org-previous-item' searches for non-empty lines by moving point up
> line by line and if there is nothing above an item point gets stuck on
> begin of buffer.
>
> example.org
> ,----
> |
> |  - Item
> `----
>
> Move point on Item, M-x org-previous-item RET and Orgmode enters the
> infinite loop.
>
> Attached patch adds a conditional clause to `org-previous-item' that
> leaves the search loop if point reaches beginning of buffer.
>
> Emacs  : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
> of 2009-11-28 on elegiac, modified by Debian
> Package: Org-mode version 6.33trans (release_6.33f.80.gb777e3)
>
> <0001-org-list.el-Prevent-infinite-loop-in-org-previous- 
> it.patch>_______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten