Re: [PATCH] Add a custom list in org-mac-link.el

[Takaaki Ishikawa <takaxp@ieee.org>]

[-- Attachment #1: Type: text/plain, Size: 2628 bytes --]

Dear Nicolas,

Thank you for your kind feedback. Please find my comments below.

> +(defcustom org-mac-link-descriptors
> > +  `(("F" "inder" org-mac-finder-insert-selected
> ,org-mac-grab-Finder-app-p)
> > +    ("m" "ail" org-mac-message-insert-selected
> ,org-mac-grab-Mail-app-p)
> > +    ("d" "EVONthink Pro Office" org-mac-devonthink-item-insert-selected
> > +     ,org-mac-grab-devonthink-app-p)
> > +    ("o" "utlook" org-mac-outlook-message-insert-selected
> ,org-mac-grab-Outlook-app-p)
> > +    ("a" "ddressbook" org-mac-addressbook-insert-selected
> ,org-mac-grab-Addressbook-app-p)
> > +    ("s" "afari" org-mac-safari-insert-frontmost-url
> ,org-mac-grab-Safari-app-p)
> > +    ("f" "irefox" org-mac-firefox-insert-frontmost-url
> ,org-mac-grab-Firefox-app-p)
> > +    ("v" "imperator" org-mac-vimperator-insert-frontmost-url
> ,org-mac-grab-Firefox+Vimperator-p)
> > +    ("c" "hrome" org-mac-chrome-insert-frontmost-url
> ,org-mac-grab-Chrome-app-p)
> > +    ("e" "evernote" org-mac-evernote-note-insert-selected
> ,org-mac-grab-Evernote-app-p)
> > +    ("t" "ogether" org-mac-together-insert-selected
> ,org-mac-grab-Together-app-p)
> > +    ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)
> > +    ("A" "crobat" org-mac-acrobat-insert-page
> ,org-mac-grab-Acrobat-app-p))
> > +  "Descriptors to select an application."
>
> Could you expand the docstring a bit? What is a descriptor, what type of
> data structure is it?
>

Updated docstring is

  "Alist of descriptors. Each descriptor consists of four elements to build
the link grabber menu in the minibuffer. A single character shall be used
for the first element to select an application, and the pair with the second
element represents the name of the application. The third element is a
function to insert information grabbed from selected application. And the
last
element is a flag to indicate whether the descriptor appears in the link
grabber menu."

Do we need more detail?

> +  :tag "A list of descriptors"
> > +  :group 'org-mac-link'
> > +  :type 'symbol)
>
> The :type value is wrong. You need a composite type here.
>

What do you feel about the following composite type.

:type '(alist :value-type (string string function boolean)


Is it useful to let the °descriptors' binding? We could simply replace
> `descriptors' with `org-mac-link-descriptors' in the `let' body. WDYT?


Yes, agree with you. I'll replace two `descriptors' in the function with
`org-mac-link-descriptors' when I produce an updated patch after receiving
your comments.

Best,
Takaaki

[-- Attachment #2: Type: text/html, Size: 3924 bytes --]