From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Takaaki Ishikawa <takaxp@ieee.org>
Cc: orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add a custom list in org-mac-link.el
Date: Thu, 15 Jun 2017 21:03:42 +0200 [thread overview]
Message-ID: <87shj1gjjl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJsv8TGOomBV4KoDg_+zhmHtv37QNANCdxYcWe-DCfv4FxTbdg@mail.gmail.com> (Takaaki Ishikawa's message of "Fri, 16 Jun 2017 03:38:55 +0900")
Takaaki Ishikawa <takaxp@ieee.org> writes:
> Thank you for your kind feedback. Please find my comments below.
Thank you for the quick answer.
> Updated docstring is
>
> "Alist of descriptors. Each descriptor consists of four elements to build
> the link grabber menu in the minibuffer. A single character shall be used
> for the first element to select an application, and the pair with the second
> element represents the name of the application. The third element is a
> function to insert information grabbed from selected application. And the
> last
> element is a flag to indicate whether the descriptor appears in the link
> grabber menu."
Nice. Note that we can make it more explicit, e.g.,
A descriptor follows the pattern:
(KEY NAME FUN FLAG)
where KEY is ...
The first line needs to end with the first sentence, i.e.,
"descriptors". Also, you need two spaces after each sentence.
>> + :tag "A list of descriptors"
>> > + :group 'org-mac-link'
>> > + :type 'symbol)
>>
>> The :type value is wrong. You need a composite type here.
>>
>
> What do you feel about the following composite type.
>
> :type '(alist :value-type (string string function boolean)
OK. You could introduce :tag to make it easier,e.g.
(string :tag "Key: ")
Regards,
prev parent reply other threads:[~2017-06-15 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 8:25 [PATCH] Add a custom list in org-mac-link.el Takaaki Ishikawa
2017-06-14 16:37 ` Nicolas Goaziou
2017-06-15 13:56 ` Takaaki Ishikawa
2017-06-15 16:32 ` Nicolas Goaziou
2017-06-15 18:38 ` Takaaki Ishikawa
2017-06-15 19:03 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shj1gjjl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=takaxp@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).