org-link-minor-mode.el broken by recent org maint

org-link-minor-mode.el broken by recent org maint

[Samuel Wales]

org-link-minor-mode broken by recent maint.  both links and tses.

anybody else?

cannot bisect but these seem suspicious by name:

439fcfb * Fix link fontification
2d29269 * Fix link fontification

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: org-link-minor-mode.el broken by recent org maint

[Nicolas Goaziou]

Hello,

Samuel Wales <samologist@gmail.com> writes:

> org-link-minor-mode broken by recent maint.  both links and tses.

I don't know what is `org-link-minor-mode'.

Regards,

-- 
Nicolas Goaziou

Re: org-link-minor-mode.el broken by recent org maint

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Thu, Jun 8, 2017, 2:52 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> Samuel Wales <samologist@gmail.com> writes:
>
> > org-link-minor-mode broken by recent maint.  both links and tses.
>
> I don't know what is `org-link-minor-mode'.
>

I don't use this package, but it looks like this one:
https://github.com/seanohalpin/org-link-minor-mode

Also it hasn't been updated in 5 years; it's from org 7 era.

> --

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1153 bytes --]

Re: org-link-minor-mode.el broken by recent org maint

[Nicolas Goaziou]

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> On Thu, Jun 8, 2017, 2:52 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
>> Hello,
>>
>> Samuel Wales <samologist@gmail.com> writes:
>>
>> > org-link-minor-mode broken by recent maint.  both links and tses.
>>
>> I don't know what is `org-link-minor-mode'.
>>
>
> I don't use this package, but it looks like this one:
> https://github.com/seanohalpin/org-link-minor-mode

OK. Thank you.

I added backward compatible aliases in "org-compat". Hopefully, this
should make the minor mode operational again.
>
> Also it hasn't been updated in 5 years; it's from org 7 era.

Samuel, would you want to contact the author and suggest him to make the
following change:

  (let ((org-link-minor-mode-keywords
         (list
          '(org-activate-angle-links (0 'org-link t))
          '(org-activate-plain-links)
          '(org-activate-bracket-links (0 'org-link t))
          '(org-activate-dates (0 'org-date t))
          ))
        ...))

  =>

  (let ((org-link-minor-mode-keywords
         '((org-activate-links))))
    ...)

Regards,

-- 
Nicolas Goaziou

Re: org-link-minor-mode.el broken by recent org maint

[Samuel Wales]

On 6/8/17, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>>> I don't know what is `org-link-minor-mode'.

it is rather nice to put org-id links in your elisp code [or any
non-org] so that you can click on them and get a description in your
org files.  or a website.  or a search link to a place in your code.

it does timestamps also.

> I added backward compatible aliases in "org-compat". Hopefully, this
> should make the minor mode operational again.

thank you.

stefan's link https://github.com/swhahn/org-link-minor-mode [possibly
his repo] looks like an up to date fork with additional changes.

> Samuel, would you want to contact the author and suggest him to make the
> following change:

swhahn seems to have made a similar change.

thanks.

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: org-link-minor-mode.el broken by recent org maint

[Stefan Hahn]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Please see:

https://github.com/swhahn/org-link-minor-mode

With kind regards,
Stefan

[-- Attachment #2: Type: text/html, Size: 176 bytes --]

Re: org-link-minor-mode.el broken by recent org maint

[Samuel Wales]

On 6/8/17, Stefan Hahn <stefan.hahn@s-hahn.de> wrote:
> Please see:
>
> https://github.com/swhahn/org-link-minor-mode

this looks great!  thanks!

getting compilation issues:

In org-link-minor-mode-unfontify-region:
org-link-minor-mode.el:30:43:Warning: `org-decompose-region' is an obsolete
    function (as of Org 9.0); use `decompose-region' instead.

In org-link-minor-mode:
org-link-minor-mode.el:66:39:Warning: variable reference to nonvariable
    `(quote (org-activate-plain-links))'
org-link-minor-mode.el:66:39:Error: Wrong type argument: symbolp,
(quote (org-activate-plain-links))

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: org-link-minor-mode.el broken by recent org maint

[Stefan-W. Hahn]

Mail von Samuel Wales, Wed, 14 Jun 2017 at 12:35:42 -0700:
> On 6/8/17, Stefan Hahn <stefan.hahn@s-hahn.de> wrote:
> > Please see:
> >
> > https://github.com/swhahn/org-link-minor-mode
> 
> this looks great!  thanks!

Thank you.

> 
> getting compilation issues:
> 
> In org-link-minor-mode-unfontify-region:
> org-link-minor-mode.el:30:43:Warning: `org-decompose-region' is an obsolete
>     function (as of Org 9.0); use `decompose-region' instead.
> 
> In org-link-minor-mode:
> org-link-minor-mode.el:66:39:Warning: variable reference to nonvariable
>     `(quote (org-activate-plain-links))'
> org-link-minor-mode.el:66:39:Error: Wrong type argument: symbolp,
> (quote (org-activate-plain-links))
> 

I just pushed a new version which now compiles without flaws togehter
with org v8 and org v9.

With kind regards,
Stefan


-- 
Stefan-W. Hahn                          It is easy to make things.
                                        It is hard to make things simple.

Re: org-link-minor-mode.el broken by recent org maint

[Samuel Wales]

Thank you!  It's useful!

On 6/15/17, Stefan-W. Hahn <stefan.hahn@s-hahn.de> wrote:
> I just pushed a new version which now compiles without flaws togehter
> with org v8 and org v9.

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.