From: Kaushal Modi <kaushal.modi@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Refactor org-set-tags arguments for clarity
Date: Thu, 13 Jul 2017 12:37:28 +0000 [thread overview]
Message-ID: <CAFyQvY0bH=Lybfa1KGB8D5s7FBmmmaTaucewBsNUD4qAywiYFA@mail.gmail.com> (raw)
In-Reply-To: <87iniwfrgg.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Thu, Jul 13, 2017 at 8:32 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Kaushal Modi <kaushal.modi@gmail.com> writes:
>
> > Correct. I was just extrapolating based on that, that people could be
> > making similar uses in their configs and packages.
> >
> > A search like this (
> >
> https://github.com/search?utf8=%E2%9C%93&q=%22org-set-tags+nil%22+language%3A%22Emacs+Lisp%22&type=Code
> > )
> > shows that (org-set-tags nil t) is pretty viral in one org-settings.el
> out
> > there.
>
> Then what about something like this
>
> (defun org-set-tags (&optional align-all align-current)
> "...
> ...
> ALIGN-CURRENT is obsolete and should not be used. When non-nil,
> set ALIGN-ALL to `current'."
> (let ((align-all (if (null align-current) align-all
> (warn "Deprecated call to `org-set-tags', which
> see")
> 'current)))
> ...))
>
That will work. Good idea!
I'll first patch maint, and then this in master.
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1798 bytes --]
next prev parent reply other threads:[~2017-07-13 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 2:46 [PATCH] Refactor org-set-tags arguments for clarity Kaushal Modi
2017-07-13 7:54 ` Nicolas Goaziou
2017-07-13 10:18 ` Kaushal Modi
2017-07-13 11:58 ` Nicolas Goaziou
2017-07-13 12:21 ` Kaushal Modi
2017-07-13 12:31 ` Nicolas Goaziou
2017-07-13 12:37 ` Kaushal Modi [this message]
2017-07-13 12:39 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY0bH=Lybfa1KGB8D5s7FBmmmaTaucewBsNUD4qAywiYFA@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).