emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Refactor org-set-tags arguments for clarity
Date: Thu, 13 Jul 2017 14:31:59 +0200	[thread overview]
Message-ID: <87iniwfrgg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY3k44hSgzomABKsd4Up7iy4FoJQvMXDWWMR1YcALpebng@mail.gmail.com> (Kaushal Modi's message of "Thu, 13 Jul 2017 12:21:32 +0000")

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Correct. I was just extrapolating based on that, that people could be
> making similar uses in their configs and packages.
>
> A search like this (
> https://github.com/search?utf8=%E2%9C%93&q=%22org-set-tags+nil%22+language%3A%22Emacs+Lisp%22&type=Code
> )
> shows that (org-set-tags nil t) is pretty viral in one org-settings.el out
> there.

Then what about something like this

  (defun org-set-tags (&optional align-all align-current)
    "...
  ...
  ALIGN-CURRENT is obsolete and should not be used. When non-nil,
  set ALIGN-ALL to `current'."
    (let ((align-all (if (null align-current) align-all
                       (warn "Deprecated call to `org-set-tags', which see")
                       'current)))
     ...))


Regards,

  reply	other threads:[~2017-07-13 12:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12  2:46 [PATCH] Refactor org-set-tags arguments for clarity Kaushal Modi
2017-07-13  7:54 ` Nicolas Goaziou
2017-07-13 10:18   ` Kaushal Modi
2017-07-13 11:58     ` Nicolas Goaziou
2017-07-13 12:21       ` Kaushal Modi
2017-07-13 12:31         ` Nicolas Goaziou [this message]
2017-07-13 12:37           ` Kaushal Modi
2017-07-13 12:39             ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iniwfrgg.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).