* Re: [PATCH] org-capture.el: Allow `(here)' as a template
[not found] <mailman.43.1687449608.14789.emacs-orgmode@gnu.org>
@ 2023-06-22 18:08 ` No Wayman
2023-06-22 18:23 ` Ihor Radchenko
0 siblings, 1 reply; 6+ messages in thread
From: No Wayman @ 2023-06-22 18:08 UTC (permalink / raw)
To: emacs-orgmode
`org-capture-store-last-position' will signal an error if a
template with a target of (here) is invoked from a buffer which is
not backed by a file.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] org-capture.el: Allow `(here)' as a template
2023-06-22 18:08 ` [PATCH] org-capture.el: Allow `(here)' as a template No Wayman
@ 2023-06-22 18:23 ` Ihor Radchenko
[not found] ` <efb6aa7502a4542218c0a5d1d6782f7bccfa69a16580a24f8baf7ddd477f3efa@mu.id>
0 siblings, 1 reply; 6+ messages in thread
From: Ihor Radchenko @ 2023-06-22 18:23 UTC (permalink / raw)
To: No Wayman; +Cc: emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
> `org-capture-store-last-position' will signal an error if a
> template with a target of (here) is invoked from a buffer which is
> not backed by a file.
What kind of error?
I was able to trigger an error when capturing from non-Org buffer, but
that's expected - org-capture is not designed for such scenarios.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] org-capture.el: Allow `(here)' as a template
[not found] ` <efb6aa7502a4542218c0a5d1d6782f7bccfa69a16580a24f8baf7ddd477f3efa@mu.id>
@ 2023-06-22 18:49 ` No Wayman
2023-06-23 11:07 ` Ihor Radchenko
0 siblings, 1 reply; 6+ messages in thread
From: No Wayman @ 2023-06-22 18:49 UTC (permalink / raw)
To: No Wayman; +Cc: Ihor Radchenko, emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
> Evaluating the following source blocking an org mode buffer with
> no backing file:
Interesting. I'm only able to reproduce it some of the time.
I'll look into it more when I have time, but it may have been an
artifact of my Emacs session.
>> I was able to trigger an error when capturing from non-Org
>> buffer, but
>> that's expected - org-capture is not designed for such
>> scenarios.
This seems unnecessarily restrictive considering there is a
"plain" entry type, but that's another issue/design consideration.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] org-capture.el: Allow `(here)' as a template
2023-06-22 18:49 ` No Wayman
@ 2023-06-23 11:07 ` Ihor Radchenko
2023-06-24 1:05 ` No Wayman
0 siblings, 1 reply; 6+ messages in thread
From: Ihor Radchenko @ 2023-06-23 11:07 UTC (permalink / raw)
To: No Wayman; +Cc: emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
>> Evaluating the following source blocking an org mode buffer with
>> no backing file:
>
> Interesting. I'm only able to reproduce it some of the time.
> I'll look into it more when I have time, but it may have been an
> artifact of my Emacs session.
I saw
Debugger entered--Lisp error: (error "Buffer not visiting a file or directory")
error("Buffer not visiting a file or directory")
bookmark-buffer-file-name()
bookmark-make-record-default()
bookmark-make-record()
bookmark-set-internal("Set bookmark named" "org-capture-last-stored" overwrite)
bookmark-set("org-capture-last-stored")
Was it the same for you?
>>> I was able to trigger an error when capturing from non-Org
>>> buffer, but
>>> that's expected - org-capture is not designed for such
>>> scenarios.
>
> This seems unnecessarily restrictive considering there is a
> "plain" entry type, but that's another issue/design consideration.
Hmm. plain entry type actually works, except the above error, which is
likely Emacs bug.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] org-capture.el: Allow `(here)' as a template
2023-06-23 11:07 ` Ihor Radchenko
@ 2023-06-24 1:05 ` No Wayman
2023-06-24 12:09 ` Ihor Radchenko
0 siblings, 1 reply; 6+ messages in thread
From: No Wayman @ 2023-06-24 1:05 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Ihor Radchenko <yantar92@posteo.net> writes:
> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
>> No Wayman <iarchivedmywholelife@gmail.com> writes:
>>
>>> Evaluating the following source blocking an org mode buffer
>>> with
>>> no backing file:
>>
>> Interesting. I'm only able to reproduce it some of the time.
>> I'll look into it more when I have time, but it may have been
>> an
>> artifact of my Emacs session.
>
> I saw
> Was it the same for you?
Yes, that's the same error. (Sorry, looks like an intermediate
message of mine got dropped)
> Hmm. plain entry type actually works, except the above error,
> which is
> likely Emacs bug.
Could be.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] org-capture.el: Allow `(here)' as a template
2023-06-24 1:05 ` No Wayman
@ 2023-06-24 12:09 ` Ihor Radchenko
0 siblings, 0 replies; 6+ messages in thread
From: Ihor Radchenko @ 2023-06-24 12:09 UTC (permalink / raw)
To: No Wayman; +Cc: emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
>>> Interesting. I'm only able to reproduce it some of the time.
>>> I'll look into it more when I have time, but it may have been
>>> an
>>> artifact of my Emacs session.
>>
>> I saw
>> Was it the same for you?
>
> Yes, that's the same error. (Sorry, looks like an intermediate
> message of mine got dropped)
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=94c2c8d92
The error was only triggered when debug-on-error is non-nil.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-24 12:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <mailman.43.1687449608.14789.emacs-orgmode@gnu.org>
2023-06-22 18:08 ` [PATCH] org-capture.el: Allow `(here)' as a template No Wayman
2023-06-22 18:23 ` Ihor Radchenko
[not found] ` <efb6aa7502a4542218c0a5d1d6782f7bccfa69a16580a24f8baf7ddd477f3efa@mu.id>
2023-06-22 18:49 ` No Wayman
2023-06-23 11:07 ` Ihor Radchenko
2023-06-24 1:05 ` No Wayman
2023-06-24 12:09 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).