emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: ox-beamer and CUSTOM_ID
Date: Fri, 16 Oct 2015 22:59:37 +0200	[thread overview]
Message-ID: <87wpumcyx2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFgFV9NdECBhGc1163+dnu39RBZ6_eCWTeaP+=Bg2XDvdfcM8w@mail.gmail.com> (Fabrice Popineau's message of "Thu, 15 Oct 2015 22:20:38 +0200")

Fabrice Popineau <fabrice.popineau@gmail.com> writes:

> My small patch worked only for labels with colon.
> With more extensive testing, I can propose this one against maint :

Thank you

> diff --git a/vendor/org-mode/lisp/ox-beamer.el
> b/vendor/org-mode/lisp/ox-beamer.el
> index 73d8a76..ee4f0d7 100644
> --- a/vendor/org-mode/lisp/ox-beamer.el
> +++ b/vendor/org-mode/lisp/ox-beamer.el
> @@ -335,11 +335,11 @@ property, or a fallback value built from headline's
> number.  This
>  function assumes HEADLINE will be treated as a frame."
>    (let ((opt (org-element-property :BEAMER_OPT headline)))
>      (if (and (stringp opt)
> -            (string-match "\\(?:^\\|,\\)label=\\(.*?\\)\\(?:$\\|,\\)" opt))
> +            (string-match "\\(?:^\\|,\\)label={?\\(.*?\\)}?\\(?:$\\|,\\)"

It would remove un-balanced curly brackets, which may or may not be
a good idea.

I took the liberty to apply a patch based off yours on maint. Hopefully,
the issue should be solved.

Regards,

      reply	other threads:[~2015-10-16 20:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 11:24 ox-beamer and CUSTOM_ID Fabrice Popineau
2015-10-13 19:26 ` Nicolas Goaziou
2015-10-13 19:38   ` Fabrice Popineau
2015-10-13 19:50     ` Nicolas Goaziou
2015-10-13 19:58       ` Fabrice Popineau
2015-10-13 20:52         ` Nicolas Goaziou
2015-10-13 21:12           ` Fabrice Popineau
2015-10-13 22:18             ` Nicolas Goaziou
2015-10-14  9:47               ` Fabrice Popineau
2015-10-14 11:57                 ` Nicolas Goaziou
2015-10-14 12:18                   ` Fabrice Popineau
2015-10-15  8:37                     ` Nicolas Goaziou
2015-10-15 16:54                       ` Fabrice Popineau
2015-10-15 19:25                         ` Fabrice Popineau
2015-10-15 19:48                           ` Nicolas Goaziou
2015-10-15 20:20                             ` Fabrice Popineau
2015-10-16 20:59                               ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpumcyx2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=fabrice.popineau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).