From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: ox-beamer and CUSTOM_ID
Date: Fri, 16 Oct 2015 22:59:37 +0200
Message-ID: <87wpumcyx2.fsf@nicolasgoaziou.fr>
References: <CAFgFV9O54WCf=_w3fGG0oujLESTN5j6bP=-RqUisRUfc-1e1OA@mail.gmail.com>
	<87pp0izi1f.fsf@nicolasgoaziou.fr>
	<CAFgFV9Nhta9VvPLU0L=nfww7Jh5nfQU178sMkWqrQVoNTKfXHA@mail.gmail.com>
	<87h9luzgyd.fsf@nicolasgoaziou.fr>
	<CAFgFV9MwZDYjNibAH+-EBMfBpNAu6KxjjkCX62PwX_Y4aU34Cg@mail.gmail.com>
	<874mhuze22.fsf@nicolasgoaziou.fr>
	<CAFgFV9MrYU8twx2BbdvMo0VSdZT7i-JPr63XgMOENMsbCr-psA@mail.gmail.com>
	<87vbaaxvia.fsf@nicolasgoaziou.fr>
	<CAFgFV9PPSLLZBhSyNJNOeyLcMS1fL7MoX0Ac7skqL350SJv_CQ@mail.gmail.com>
	<87k2qpy85j.fsf@nicolasgoaziou.fr>
	<CAFgFV9OP19OF-XdcccNZNX34BCheHXRzYBfZquOev87TrwUx3A@mail.gmail.com>
	<87wpuowmrn.fsf@nicolasgoaziou.fr>
	<CAFgFV9Mp3gT2QR=RkjKqkTY6bU0C9TotmSjkzMMqaZyzzbmisg@mail.gmail.com>
	<CAFgFV9MTnd-_PXNbWzYMz87Q8Fsj2OS3Xj388TtTGpfMrBJLhA@mail.gmail.com>
	<87oafz6hgx.fsf@nicolasgoaziou.fr>
	<CAFgFV9NdECBhGc1163+dnu39RBZ6_eCWTeaP+=Bg2XDvdfcM8w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZnC4a-0008NC-5R
	for emacs-orgmode@gnu.org; Fri, 16 Oct 2015 16:57:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZnC4Z-0005DY-AK
	for emacs-orgmode@gnu.org; Fri, 16 Oct 2015 16:57:56 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:35902)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZnC4Z-0005DB-3b
	for emacs-orgmode@gnu.org; Fri, 16 Oct 2015 16:57:55 -0400
In-Reply-To: <CAFgFV9NdECBhGc1163+dnu39RBZ6_eCWTeaP+=Bg2XDvdfcM8w@mail.gmail.com>
	(Fabrice Popineau's message of "Thu, 15 Oct 2015 22:20:38 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Fabrice Popineau <fabrice.popineau@gmail.com> writes:

> My small patch worked only for labels with colon.
> With more extensive testing, I can propose this one against maint :

Thank you

> diff --git a/vendor/org-mode/lisp/ox-beamer.el
> b/vendor/org-mode/lisp/ox-beamer.el
> index 73d8a76..ee4f0d7 100644
> --- a/vendor/org-mode/lisp/ox-beamer.el
> +++ b/vendor/org-mode/lisp/ox-beamer.el
> @@ -335,11 +335,11 @@ property, or a fallback value built from headline's
> number.  This
>  function assumes HEADLINE will be treated as a frame."
>    (let ((opt (org-element-property :BEAMER_OPT headline)))
>      (if (and (stringp opt)
> -            (string-match "\\(?:^\\|,\\)label=\\(.*?\\)\\(?:$\\|,\\)" opt))
> +            (string-match "\\(?:^\\|,\\)label={?\\(.*?\\)}?\\(?:$\\|,\\)"

It would remove un-balanced curly brackets, which may or may not be
a good idea.

I took the liberty to apply a patch based off yours on maint. Hopefully,
the issue should be solved.

Regards,