emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Lele Gaifax <lele@metapensiero.it>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-colview.el: Fix typo in function name
Date: Fri, 24 Jun 2016 14:26:30 +0200	[thread overview]
Message-ID: <87wpleu615.fsf_-_@metapensiero.it> (raw)
In-Reply-To: 871t3mvlfc.fsf@metapensiero.it

>>> BTW, in lisp/org-colview.el there is what seems a typo in the name of the
>>> function `org-columns-hscoll-title`: since accordingly with "git grep" it is
>>> referenced in two places and only in that source, is the following
>>> acceptable?
>>
>> Sure. Could you provide a proper commit message and send the patch using
>> "git format-patch" command? See
>> <http://orgmode.org/worg/org-contribute.html#patches> for details.

Here it is!

From 7919e3ecb9362451a2f1f5e919e378dadadaf8de Mon Sep 17 00:00:00 2001
From: Lele Gaifax <lele@metapensiero.it>
Date: Fri, 24 Jun 2016 14:14:34 +0200
Subject: [PATCH] org-colview.el: Fix typo in function name

* lisp/org-colview.el (org-columns-hscroll-title): rename from
  `org-columns-hscoll-title'
(org-columns--display-here-title): adjust reference to renamed function
(org-columns-remove-overlays): likewise
---
 lisp/org-colview.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 864b221..d26f16a 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -438,9 +438,9 @@ for the duration of the command.")
 	   (org-add-props " " nil 'display '(space :align-to 0))
 	   (org-add-props (substring title 0 -1) nil 'face 'org-column-title)))
     (setq org-columns-previous-hscroll -1)
-    (add-hook 'post-command-hook 'org-columns-hscoll-title nil 'local)))
+    (add-hook 'post-command-hook 'org-columns-hscroll-title nil 'local)))
 
-(defun org-columns-hscoll-title ()
+(defun org-columns-hscroll-title ()
   "Set the `header-line-format' so that it scrolls along with the table."
   (sit-for .0001) ; need to force a redisplay to update window-hscroll
   (when (not (= (window-hscroll) org-columns-previous-hscroll))
@@ -463,7 +463,7 @@ for the duration of the command.")
       (when (local-variable-p 'org-previous-header-line-format)
 	(setq header-line-format org-previous-header-line-format)
 	(kill-local-variable 'org-previous-header-line-format)
-	(remove-hook 'post-command-hook 'org-columns-hscoll-title 'local))
+	(remove-hook 'post-command-hook 'org-columns-hscroll-title 'local))
       (move-marker org-columns-begin-marker nil)
       (move-marker org-columns-top-level-marker nil)
       (org-with-silent-modifications
-- 
2.8.1

Thank you,
ciao, lele.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it  |                 -- Fortunato Depero, 1929.

  reply	other threads:[~2016-06-24 12:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-31  3:38 latex-export + columnview: misinterpretation of section prefixes as emphasis Juan Pechiar
     [not found] ` <D96E521D-17DE-4725-AD9A-363522C9B1E9@tsdye.com>
     [not found]   ` <20100531130409.GE27574@soloJazz.com>
2010-05-31 16:57     ` Thomas S. Dye
2010-06-01  7:32 ` Carsten Dominik
2010-06-01 10:51   ` Tim Burt
2010-06-01 13:34     ` Carsten Dominik
2010-06-01 14:52       ` tcburt
2016-06-22 18:45 ` Lele Gaifax
2016-06-22 19:56   ` Nicolas Goaziou
2016-06-22 20:16     ` Lele Gaifax
2016-06-22 20:46       ` Nicolas Goaziou
2016-06-23  6:36         ` Lele Gaifax
2016-06-24  9:38           ` Nicolas Goaziou
2016-06-24 12:08             ` Lele Gaifax
2016-06-24 12:26               ` Lele Gaifax [this message]
2016-06-24 12:49                 ` [PATCH] org-colview.el: Fix typo in function name Nicolas Goaziou
2016-06-24 13:06                   ` Lele Gaifax
2016-06-24 14:01                     ` Nicolas Goaziou
2016-06-24 12:47               ` latex-export + columnview: misinterpretation of section prefixes as emphasis Nicolas Goaziou
2016-06-24 13:03                 ` Lele Gaifax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpleu615.fsf_-_@metapensiero.it \
    --to=lele@metapensiero.it \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).