* org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1
@ 2023-10-25 13:42 Max Nikulin
2023-10-25 13:50 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: Max Nikulin @ 2023-10-25 13:42 UTC (permalink / raw)
To: emacs-orgmode
Hi,
There is a warning during org compiling:
> In org-element--properties-mapc:
> org-element-ast.el:628:25: Warning: ‘not’ called with 3 args, but requires 1
> org-element-ast.el:628:30: Warning: reference to free variable ‘eq’
Likely it is a typo
diff --git a/lisp/org-element-ast.el b/lisp/org-element-ast.el
index c4c6d1c6f..f07a5f935 100644
--- a/lisp/org-element-ast.el
+++ b/lisp/org-element-ast.el
@@ -607,7 +607,7 @@ (defun org-element--properties-mapc (fun node
&optional collect no-standard)
node))))
(when collect
(unless (eq rtn (aref parray (cadr standard-idxs)))
- (if (and (eq collect 'set) (not eq rtn
'org-element-ast--nil))
+ (if (and (eq collect 'set) (not (eq rtn
'org-element-ast--nil)))
(setf (aref parray (cadr standard-idxs)) rtn)
(push rtn acc))))
(setq standard-idxs (cddr standard-idxs))))))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1
2023-10-25 13:42 org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1 Max Nikulin
@ 2023-10-25 13:50 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2023-10-25 13:50 UTC (permalink / raw)
To: Max Nikulin; +Cc: emacs-orgmode
Max Nikulin <manikulin@gmail.com> writes:
> There is a warning during org compiling:
>
>> In org-element--properties-mapc:
>> org-element-ast.el:628:25: Warning: ‘not’ called with 3 args, but requires 1
>> org-element-ast.el:628:30: Warning: reference to free variable ‘eq’
>
> Likely it is a typo
>
> diff --git a/lisp/org-element-ast.el b/lisp/org-element-ast.el
> index c4c6d1c6f..f07a5f935 100644
> --- a/lisp/org-element-ast.el
> +++ b/lisp/org-element-ast.el
> @@ -607,7 +607,7 @@ (defun org-element--properties-mapc (fun node
> &optional collect no-standard)
> node))))
> (when collect
> (unless (eq rtn (aref parray (cadr standard-idxs)))
> - (if (and (eq collect 'set) (not eq rtn
> 'org-element-ast--nil))
> + (if (and (eq collect 'set) (not (eq rtn
> 'org-element-ast--nil)))
Thanks!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=55db64e9d
The irony is that I saw the warning, looked into the code, and somehow
thought that it is a false-positive (the warning is not displayed in all
the Emacs versions).
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-25 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-25 13:42 org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1 Max Nikulin
2023-10-25 13:50 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).