emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thomas Holst <Thomas_Holst@gmx.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-capture regression?
Date: Thu, 20 Sep 2018 14:53:03 +0200	[thread overview]
Message-ID: <87sh24gwk0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r2ho60xn.fsf@gmx.de> (Thomas Holst's message of "Thu, 20 Sep 2018 10:13:56 +0200")

Hello,

Thomas Holst <Thomas_Holst@gmx.de> writes:

> a view weeks ago a wrote a post about problems I have with one of my
> captue templates. (see:
> http://lists.gnu.org/archive/html/emacs-orgmode/2018-08/msg00161.html)

I thought I had answered it.

> Since a few weeks this is not working anymore. I have a capture template
> unsing this feature (which I use rarely but still).
>
> So here is I patch I came up with to re-enable theese features:

Thank you. However, I have two issues with it.

The first one is that I don't like `eval'. See, for example, this
excerpt from the Elisp manual:

    On rare occasions, you may need to write code that evaluates a form
    that is computed at run time, such as after reading a form from text
    being edited or getting one from a property list. On these
    occasions, use the ‘eval’ function. Often ‘eval’ is not needed and
    something else should be used instead. For example, to get the value
    of a variable, while ‘eval’ works, ‘symbol-value’ is preferable; or
    rather than store expressions in a property list that then need to
    go through ‘eval’, it is better to store functions instead that are
    then passed to ‘funcall’.

So, I'd rather use `symbol-value' and `funcall' and forbid arbitrary
Sexps.

Also, this introduces a discrepancy between :table-line-pos and other
parameters, which do not allow variables nor functions. This is another
issue.

IOW, it may need be to be implemented at a lower level, with proper
tooling.

WDYT?

> This works for me. I can use my capture template again. In the
>meantime I signed FSF papers so TINYCHANGE is not required anymore.

Great!

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2018-09-20 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20  8:13 org-capture regression? Thomas Holst
2018-09-20 12:53 ` Nicolas Goaziou [this message]
2018-09-20 14:01   ` Thomas Holst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh24gwk0.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=Thomas_Holst@gmx.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).