From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: org-capture regression? Date: Thu, 20 Sep 2018 14:53:03 +0200 Message-ID: <87sh24gwk0.fsf@nicolasgoaziou.fr> References: <87r2ho60xn.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2ySD-0004FO-U7 for emacs-orgmode@gnu.org; Thu, 20 Sep 2018 08:53:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2ySA-0003LL-L8 for emacs-orgmode@gnu.org; Thu, 20 Sep 2018 08:53:09 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34733) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g2ySA-0003Jn-Di for emacs-orgmode@gnu.org; Thu, 20 Sep 2018 08:53:06 -0400 In-Reply-To: <87r2ho60xn.fsf@gmx.de> (Thomas Holst's message of "Thu, 20 Sep 2018 10:13:56 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Thomas Holst Cc: emacs-orgmode@gnu.org Hello, Thomas Holst writes: > a view weeks ago a wrote a post about problems I have with one of my > captue templates. (see: > http://lists.gnu.org/archive/html/emacs-orgmode/2018-08/msg00161.html) I thought I had answered it. > Since a few weeks this is not working anymore. I have a capture template > unsing this feature (which I use rarely but still). > > So here is I patch I came up with to re-enable theese features: Thank you. However, I have two issues with it. The first one is that I don't like `eval'. See, for example, this excerpt from the Elisp manual: On rare occasions, you may need to write code that evaluates a form that is computed at run time, such as after reading a form from text being edited or getting one from a property list. On these occasions, use the =E2=80=98eval=E2=80=99 function. Often =E2=80=98eval= =E2=80=99 is not needed and something else should be used instead. For example, to get the value of a variable, while =E2=80=98eval=E2=80=99 works, =E2=80=98symbol-valu= e=E2=80=99 is preferable; or rather than store expressions in a property list that then need to go through =E2=80=98eval=E2=80=99, it is better to store functions inst= ead that are then passed to =E2=80=98funcall=E2=80=99. So, I'd rather use `symbol-value' and `funcall' and forbid arbitrary Sexps. Also, this introduces a discrepancy between :table-line-pos and other parameters, which do not allow variables nor functions. This is another issue. IOW, it may need be to be implemented at a lower level, with proper tooling. WDYT? > This works for me. I can use my capture template again. In the >meantime I signed FSF papers so TINYCHANGE is not required anymore. Great! Regards, --=20 Nicolas Goaziou