Re: [PATCH] protocol: allow users to disable warning about old style links

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Alex Branham <branham@utexas.edu> writes:

> I did report it upstream as a bug. The maintainer is (understandably,
> I think) hesitant to change since 1) old style links continue to be
> supported

But it will break at some point, hence the warning.

> and 2) there’s no way for a browser extension to detect the
> version of org-mode to install. Since new style links aren’t supported
> in older org versions (like what comes shipped with Emacs), that could
> create issues.

True. Note that Org shipped with Emacs is no longer supported.
Hopefully, Emacs 26.1 will ship with a brand new Org mode.

IIUC, one issue is that the developers of the extension wants to support
multiple Org versions. That's fair, but then, they could implement an
option to generate any of the two styles. It would also make the
transition easier when one of them is dropped.

> I changed it to a defvar and modified the warning. That seems simpler to me.
>
> I wasn’t sure if defvars should go into org-compat.el (that file says
> it’s for compatibility issues with older Emacs versions?) or stay
> where it is. I’ve left it where it is for now but I can move it to
> org-compat.el if you want me to.

"org-compat.el" is about compatibility in the broad sense. It should
contain any volatile code, i.e., code that can be removed in a future
major release.

This variable can go in "org-compat".

>>> +(defcustom org-protocol-warn-about-old-links t
>>> +  "If non-nil (the default), issue a warning when org protocol
>>> +receives old style links."

You forgot to update the docstring.

In any case, I think the extension could offer both styles instead of
adding this variable.

Thank you.

Regards,