From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] protocol: allow users to disable warning about old style links Date: Fri, 16 Jun 2017 16:26:16 +0200 Message-ID: <87mv98f1pz.fsf@nicolasgoaziou.fr> References: <8737b2bwg9.fsf@utexas.edu> <8737b0h33u.fsf@nicolasgoaziou.fr> <878tksb23w.fsf@utexas.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLsCb-0003OL-Sz for emacs-orgmode@gnu.org; Fri, 16 Jun 2017 10:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLsCa-0000Xe-RB for emacs-orgmode@gnu.org; Fri, 16 Jun 2017 10:26:21 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59743) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dLsCa-0000Vr-L3 for emacs-orgmode@gnu.org; Fri, 16 Jun 2017 10:26:20 -0400 In-Reply-To: <878tksb23w.fsf@utexas.edu> (Alex Branham's message of "Fri, 16 Jun 2017 13:31:31 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Alex Branham Cc: emacs-orgmode@gnu.org Alex Branham writes: > I did report it upstream as a bug. The maintainer is (understandably, > I think) hesitant to change since 1) old style links continue to be > supported But it will break at some point, hence the warning. > and 2) there=E2=80=99s no way for a browser extension to detect the > version of org-mode to install. Since new style links aren=E2=80=99t supp= orted > in older org versions (like what comes shipped with Emacs), that could > create issues. True. Note that Org shipped with Emacs is no longer supported. Hopefully, Emacs 26.1 will ship with a brand new Org mode. IIUC, one issue is that the developers of the extension wants to support multiple Org versions. That's fair, but then, they could implement an option to generate any of the two styles. It would also make the transition easier when one of them is dropped. > I changed it to a defvar and modified the warning. That seems simpler to = me. > > I wasn=E2=80=99t sure if defvars should go into org-compat.el (that file = says > it=E2=80=99s for compatibility issues with older Emacs versions?) or stay > where it is. I=E2=80=99ve left it where it is for now but I can move it to > org-compat.el if you want me to. "org-compat.el" is about compatibility in the broad sense. It should contain any volatile code, i.e., code that can be removed in a future major release. This variable can go in "org-compat". >>> +(defcustom org-protocol-warn-about-old-links t >>> + "If non-nil (the default), issue a warning when org protocol >>> +receives old style links." You forgot to update the docstring. In any case, I think the extension could offer both styles instead of adding this variable. Thank you. Regards,