emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* toggling checkbox with one prefix arg modifies drawer contents
@ 2018-01-15  1:14 Samuel Wales
  2018-01-15 13:31 ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Samuel Wales @ 2018-01-15  1:14 UTC (permalink / raw)
  To: emacs-orgmode

> If the cursor is in a headline, apply this to all checkbox items
in the text below the heading, taking as reference the first item
in subtree, ignoring drawers.

in recent maint this seems to affect state change lines in logbook.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: toggling checkbox with one prefix arg modifies drawer contents
  2018-01-15  1:14 toggling checkbox with one prefix arg modifies drawer contents Samuel Wales
@ 2018-01-15 13:31 ` Nicolas Goaziou
  2018-01-15 20:27   ` Samuel Wales
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2018-01-15 13:31 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Hello,

Samuel Wales <samologist@gmail.com> writes:

>> If the cursor is in a headline, apply this to all checkbox items
> in the text below the heading, taking as reference the first item
> in subtree, ignoring drawers.
>
> in recent maint this seems to affect state change lines in logbook.

It could. It depends where is located the logbook. "Ignoring drawers" in
the docstring is a bit terse. It should be "ignoring any drawer right
after the headline".

Do you have an ECM demonstrating the issue?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: toggling checkbox with one prefix arg modifies drawer contents
  2018-01-15 13:31 ` Nicolas Goaziou
@ 2018-01-15 20:27   ` Samuel Wales
  2018-01-15 22:16     ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Samuel Wales @ 2018-01-15 20:27 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

On 1/15/18, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> It could. It depends where is located the logbook. "Ignoring drawers" in
> the docstring is a bit terse. It should be "ignoring any drawer right
> after the headline".

imo only body text should be modified.

> Do you have an ECM demonstrating the issue?

no.  it should look like this:

***************** NEXTREPEAT [#A] [15/109] [13%] whatever :physical:goto:
SCHEDULED: <2018-02-11 Sun .+4w>
:PROPERTIES:
:ID:       a33ee4af-43ae-4a3e-9349-f14a22a58eaa
:END:
:LOGBOOK:
- State "DONE"       from "NEXTREPEAT" [2018-01-14 Sun 20:24]
:END:

  1.  [X] consider
  2.  [-] pre
      1) [X] smart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: toggling checkbox with one prefix arg modifies drawer contents
  2018-01-15 20:27   ` Samuel Wales
@ 2018-01-15 22:16     ` Nicolas Goaziou
  2018-01-16  0:11       ` Samuel Wales
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2018-01-15 22:16 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Samuel Wales <samologist@gmail.com> writes:

> On 1/15/18, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> It could. It depends where is located the logbook. "Ignoring drawers" in
>> the docstring is a bit terse. It should be "ignoring any drawer right
>> after the headline".
>
> imo only body text should be modified.

They are, arguably, body text.

>> Do you have an ECM demonstrating the issue?
>
> no.  it should look like this:
>
> ***************** NEXTREPEAT [#A] [15/109] [13%] whatever :physical:goto:
> SCHEDULED: <2018-02-11 Sun .+4w>
> :PROPERTIES:
> :ID:       a33ee4af-43ae-4a3e-9349-f14a22a58eaa
> :END:
> :LOGBOOK:
> - State "DONE"       from "NEXTREPEAT" [2018-01-14 Sun 20:24]
> :END:
>
>   1.  [X] consider
>   2.  [-] pre
>       1) [X] smart

Fixed. Thank you.

Regards,

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: toggling checkbox with one prefix arg modifies drawer contents
  2018-01-15 22:16     ` Nicolas Goaziou
@ 2018-01-16  0:11       ` Samuel Wales
  2018-01-16  8:43         ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Samuel Wales @ 2018-01-16  0:11 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

thank you.

On 1/15/18, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> They are, arguably, body text.

what is the name of "the text after anything that org might typically modify"?

[i recognize this is not a perfect question.  repeaters are modified
by org.  if events were in the planning line it might be a bit more
perfect question.]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: toggling checkbox with one prefix arg modifies drawer contents
  2018-01-16  0:11       ` Samuel Wales
@ 2018-01-16  8:43         ` Nicolas Goaziou
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2018-01-16  8:43 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Hello,

Samuel Wales <samologist@gmail.com> writes:

> On 1/15/18, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> They are, arguably, body text.
>
> what is the name of "the text after anything that org might typically
> modify"?

There is no such thing. Org may modify something anywhere in an entry.
For example, the logbook drawer could be just before the next headline.

The closest definition we have is `org-end-of-meta-data', hence the
behaviour of `org-toggle-checkbox'.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-01-16  8:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15  1:14 toggling checkbox with one prefix arg modifies drawer contents Samuel Wales
2018-01-15 13:31 ` Nicolas Goaziou
2018-01-15 20:27   ` Samuel Wales
2018-01-15 22:16     ` Nicolas Goaziou
2018-01-16  0:11       ` Samuel Wales
2018-01-16  8:43         ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).