* [PATCH] org-protocol.el: Fix `org-protocol-capture' return value
@ 2018-12-18 22:17 Renato Ferreira
2018-12-19 21:17 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Renato Ferreira @ 2018-12-18 22:17 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
Hello,
This fixes `org-protocol-capture' removing the message because protocols
with :kill-client exit it with `server-edit' causing
`server-visit-files' to receive "Item captured." which it interpret as a
file name.
--
Renato Ferreira
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-protocol.el-Fix-org-protocol-capture-return-valu.patch --]
[-- Type: text/x-patch, Size: 897 bytes --]
From 50a575a9816d65ae02443a149070763bf33b5213 Mon Sep 17 00:00:00 2001
From: Renato Ferreira <renatofdds@gmail.com>
Date: Tue, 18 Dec 2018 20:00:11 -0200
Subject: [PATCH] org-protocol.el: Fix `org-protocol-capture' return value
* lisp/org-protocol.el: Make sure protocols with :kill-client do
not return a string.
TINYCHANGE
---
lisp/org-protocol.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index 88f471e7d..48d72db1c 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -503,8 +503,7 @@ Now template ?b will be used."
:initial region
:query parts)
(raise-frame)
- (org-capture nil template))
- (message "Item captured."))
+ (org-capture nil template)))
(defun org-protocol-convert-query-to-plist (query)
"Convert QUERY key=value pairs in the URL to a property list."
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] org-protocol.el: Fix `org-protocol-capture' return value
2018-12-18 22:17 [PATCH] org-protocol.el: Fix `org-protocol-capture' return value Renato Ferreira
@ 2018-12-19 21:17 ` Nicolas Goaziou
2018-12-19 21:51 ` Renato Ferreira
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2018-12-19 21:17 UTC (permalink / raw)
To: Renato Ferreira; +Cc: emacs-orgmode
Hello,
Renato Ferreira <renatofdds@gmail.com> writes:
> This fixes `org-protocol-capture' removing the message because protocols
> with :kill-client exit it with `server-edit' causing
> `server-visit-files' to receive "Item captured." which it interpret as a
> file name.
Thank you. I applied your patch with a slight modification.
Let me know if it fixes the issue.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] org-protocol.el: Fix `org-protocol-capture' return value
2018-12-19 21:17 ` Nicolas Goaziou
@ 2018-12-19 21:51 ` Renato Ferreira
0 siblings, 0 replies; 3+ messages in thread
From: Renato Ferreira @ 2018-12-19 21:51 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
On Wed, 19 Dec 2018 22:17:47 +0100, Nicolas Goaziou <mail@nicolasgoaziou.fr> said:
> Let me know if it fixes the issue.
Fixed. Thank you very much!
--
Renato Ferreira
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-19 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 22:17 [PATCH] org-protocol.el: Fix `org-protocol-capture' return value Renato Ferreira
2018-12-19 21:17 ` Nicolas Goaziou
2018-12-19 21:51 ` Renato Ferreira
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).