Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)]

Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)]

[email]

Greetings fellow org-mode enthusiasts,

I discovered that in the latest org-mode setting
(org-archive-subtree-add-inherited-tags t) only includes inherited tags
but omits local tags.

To remedy this I propose the following patch to org-archive.el:


diff --git a/org-archive.el b/org-archive.el
index e020ec2..0ac164d 100644
--- a/org-archive.el
+++ b/org-archive.el
@@ -361,7 +361,7 @@ direct children of this heading."
                   (or (and (eq org-archive-subtree-add-inherited-tags
'infile)
                            infile-p)
                       (eq org-archive-subtree-add-inherited-tags t))
-                  (org-set-tags-to all-tags))
+                  (org-set-tags-to (delete-dups (append inherited-tags
local-tags))))
              ;; Mark the entry as done
              (when (and org-archive-mark-done
                         (let ((case-fold-search nil))


However, I am not sure if this is enough or if something more fundamental
is broken since all-tags only includes inherited tags and not actually all
tags.

Best regards,

Edgar Kalkowski


Emacs  : GNU Emacs 25.3.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
 of 2018-02-09
Package: Org mode version 9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)

Re: Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)]

[Nicolas Goaziou]

Hello,

email@edgar-kalkowski.de writes:

> Greetings fellow org-mode enthusiasts,
>
> I discovered that in the latest org-mode setting
> (org-archive-subtree-add-inherited-tags t) only includes inherited tags
> but omits local tags.

[...]

> However, I am not sure if this is enough or if something more fundamental
> is broken since all-tags only includes inherited tags and not actually all
> tags.

Could you test again with master? I think this was fixed recently there.

Thank you.

Regards,

-- 
Nicolas Goaziou