[PATCH] Fix the call to `org-expiry-handler-function'

[PATCH] Fix the call to `org-expiry-handler-function'

[Samuel Loury]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

`org-expiry-handler-function' is meant to be a variable containing the symbol of
a function to be called.

Therefore, calling (funcall 'org-expiry-handler-function) results in a
void function error while (funcall org-expiry-handler-function)
correctly calls the contained function.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Fix-the-call-to-org-expiry-handler-function.patch --]
[-- Type: text/x-diff, Size: 1263 bytes --]

From 8eedc132e7524b78bf435cf41cf303257b4c73dc Mon Sep 17 00:00:00 2001
From: Konubinix <konubinix@gmail.com>
Date: Thu, 6 Nov 2014 09:20:22 +0100
Subject: [PATCH 1/2] Fix the call to `org-expiry-handler-function'

* contrib/lisp/org-expiry.el (org-expiry-process-entry): Fix the call to
`org-expiry-handler-function'.

`org-expiry-handler-function' is meant to be a variable containing the symbol of
a function to be called. Therefore, calling
(funcall 'org-expiry-handler-function) results in a void function error while
(funcall org-expiry-handler-function) correctly calls the contained function.
---
 contrib/lisp/org-expiry.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/lisp/org-expiry.el b/contrib/lisp/org-expiry.el
index cd36d08..67dc89e 100644
--- a/contrib/lisp/org-expiry.el
+++ b/contrib/lisp/org-expiry.el
@@ -253,7 +253,7 @@ Otherwise rely on `org-expiry-confirm-flag' to decide."
 		     (not (interactive)))
 		(and org-expiry-confirm-flag
 		     (y-or-n-p (format "Entry expired by %d days.  Process? " d))))
-	  (funcall 'org-expiry-handler-function))
+	  (funcall org-expiry-handler-function))
 	(delete-overlay ov)))))
 
 (defun org-expiry-process-entries (beg end)
-- 
2.9.3


[-- Attachment #1.3: Type: text/plain, Size: 104 bytes --]

-- 
Konubinix
GPG Key    : 7439106A
Fingerprint: 5993 BE7A DA65 E2D9 06CE  5C36 75D2 3CED 7439 106A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: [PATCH] Fix the call to `org-expiry-handler-function'

[Nicolas Goaziou]

Hello,

Samuel Loury <konubinix@gmail.com> writes:

> `org-expiry-handler-function' is meant to be a variable containing the symbol of
> a function to be called.
>
> Therefore, calling (funcall 'org-expiry-handler-function) results in a
> void function error while (funcall org-expiry-handler-function)
> correctly calls the contained function.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou