emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] TINYCHANGE - fix Fix use of org-open-at-point with shell and midnight cleaning
@ 2015-04-29 13:42 Luke Amdor
  2015-04-29 21:41 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Luke Amdor @ 2015-04-29 13:42 UTC (permalink / raw)
  To: org-mode Mode


[-- Attachment #1.1: Type: text/plain, Size: 136 bytes --]

Patch is attached. I was running into this when I'd run a shell script
through an org link and later a clean-buffers would run. Thanks!

[-- Attachment #1.2: Type: text/html, Size: 161 bytes --]

[-- Attachment #2: 0001-org.el-Fix-use-of-org-open-at-point-with-shell-and-m.patch --]
[-- Type: application/octet-stream, Size: 933 bytes --]

From 6a9dce8de4f8f14f3ffa482e64fb08fe6519d87e Mon Sep 17 00:00:00 2001
From: Luke Amdor <luke.amdor@gmail.com>
Date: Tue, 28 Apr 2015 17:44:17 -0500
Subject: [PATCH] org.el: Fix use of org-open-at-point with shell and midnight
 cleaning

* lisp/org.el (org-open-at-point): Make sure org shell output buffer is a string of buffer name before appending to `clean-buffer-list-kill-buffer-names' for cleaning later.

TINYCHANGE
---
 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 4635ee8..e2d1724 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10836,7 +10836,7 @@ link in a property drawer line."
 			(shell-command cmd buf)
 			(when (featurep 'midnight)
 			  (setq clean-buffer-list-kill-buffer-names
-				(cons buf
+				(cons (buffer-name buf)
 				      clean-buffer-list-kill-buffer-names))))
 		    (user-error "Abort"))))
 	       ((equal type "elisp")
-- 
2.3.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] TINYCHANGE - fix Fix use of org-open-at-point with shell and midnight cleaning
  2015-04-29 13:42 [PATCH] TINYCHANGE - fix Fix use of org-open-at-point with shell and midnight cleaning Luke Amdor
@ 2015-04-29 21:41 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2015-04-29 21:41 UTC (permalink / raw)
  To: Luke Amdor; +Cc: org-mode Mode

Hello,

Luke Amdor <luke.amdor@gmail.com> writes:

> Subject: [PATCH] org.el: Fix use of org-open-at-point with shell and midnight
>  cleaning
>
> * lisp/org.el (org-open-at-point): Make sure org shell output buffer
> is a string of buffer name before appending to
> `clean-buffer-list-kill-buffer-names' for cleaning later.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-29 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-29 13:42 [PATCH] TINYCHANGE - fix Fix use of org-open-at-point with shell and midnight cleaning Luke Amdor
2015-04-29 21:41 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).