* [BUG] ox-beamer uses ox-latex private functions
@ 2023-12-22 21:21 Niall Dooley
2023-12-23 10:22 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Niall Dooley @ 2023-12-22 21:21 UTC (permalink / raw)
To: emacs-orgmode
In three separate places (lines 779, 825 and 874) ox-beamer uses
ox-latex private functions namely:
line779: `org-latex--wrap-label'
line 825: `org-latex--insert-compiler'
line 874: `org-latex--format-spec'
I appreciate ox-beamer is a backend backend derived from ox-latex but
isn't this bad practice if these private functions were to change in
future?
Emacs: GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.24, cairo version 1.16.0) of 2023-02-23, modified by Debian
Package: Org mode version 9.7-pre (release_9.6.9-818-gac108a)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] ox-beamer uses ox-latex private functions
2023-12-22 21:21 [BUG] ox-beamer uses ox-latex private functions Niall Dooley
@ 2023-12-23 10:22 ` Ihor Radchenko
2023-12-23 17:43 ` Niall Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2023-12-23 10:22 UTC (permalink / raw)
To: Niall Dooley; +Cc: emacs-orgmode
Niall Dooley <dooleyn@gmail.com> writes:
> In three separate places (lines 779, 825 and 874) ox-beamer uses
> ox-latex private functions namely:
>
> line779: `org-latex--wrap-label'
> line 825: `org-latex--insert-compiler'
> line 874: `org-latex--format-spec'
>
> I appreciate ox-beamer is a backend backend derived from ox-latex but
> isn't this bad practice if these private functions were to change in
> future?
Both ox-beamer and ox-latex are parts of Org mode. So, there is nothing
wrong with using these internal functions - we have the control over all
parts of Org mode. If we decide to make a breaking change in any
internal function in Org mode, its users in Org source code must be
changed; be it the same file or not.
Not a bug.
Canceled.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] ox-beamer uses ox-latex private functions
2023-12-23 10:22 ` Ihor Radchenko
@ 2023-12-23 17:43 ` Niall Dooley
0 siblings, 0 replies; 3+ messages in thread
From: Niall Dooley @ 2023-12-23 17:43 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
On Sat, 23 Dec 2023 at 11:19, Ihor Radchenko <yantar92@posteo.net> wrote:
> Both ox-beamer and ox-latex are parts of Org mode. So, there is nothing
> wrong with using these internal functions - we have the control over all
> parts of Org mode. If we decide to make a breaking change in any
> internal function in Org mode, its users in Org source code must be
> changed; be it the same file or not.
OK, thanks for the clarification.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-23 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22 21:21 [BUG] ox-beamer uses ox-latex private functions Niall Dooley
2023-12-23 10:22 ` Ihor Radchenko
2023-12-23 17:43 ` Niall Dooley
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).