From: David Maus <maus.david@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Bug: org-wl: from property not set as expected [6.33]
Date: Sat, 14 Nov 2009 12:43:28 +0100 [thread overview]
Message-ID: <87bpj5jpr3.wl%maus.david@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5147 bytes --]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
When storing a link to a Wanderlust message the link's :from property
is not set to the full address field (i.e. Name <email>) if the
Wanderlust customization variable `wl-use-petname' is set to 't, what
is it's default value.
This causes unexpected behavior when `org-store-link' is called for a
remember template as the template's :fromname and :fromaddress
properties are not set correctly: %:fromname is empty and :fromaddress
contains the senders name and not the address.
This misbehaviour is caused because `org-wl-store-link' calls
`wl-summary-line-from' which respects `wl-use-petname' and returns the
senders name only if this variable is set to 't.
Attached patch changes this issue by simply make `org-wl-store-link'
use the same code to get the from field as it does for the to field.
Emacs : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
of 2009-10-23 on elegiac, modified by Debian
Package: Org-mode version 6.33
current state:
==============
(setq
org-clock-in-switch-to-state "STARTED"
org-todo-keyword-faces '(("TODO" :foreground "red" :weight bold) ("STARTED" :foreground "orange red" :weight bold)
("DONE" :foreground "light green") ("MAYBE" :foreground "tomato")
("WAITING" :foreground "tan2" :weight bold) ("CANCELLED" :foreground "firebrick")
("APPT" :foreground "DeepSkyBlue1" :weight bold) ("DEFERRED" :foreground "light slate gray"))
org-agenda-custom-commands '(("r" "Refile New Notes and Tasks" tags "LEVEL=1+REFILE"
((org-agenda-todo-ignore-with-date nil)))
("s" "Started Tasks" todo "STARTED"
((org-agenda-todo-ignore-scheduled nil) (org-agenda-todo-ignore-deadlines nil)
(org-agenda-todo-ignore-with-date nil))
)
)
org-agenda-files '("/home/david/Org/pg.org" "/home/david/Org/work.org" "/home/david/Org/tec.org" "/home/david/Org/priv.org"
"/home/david/Org/refile.org")
org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
org-agenda-tags-column -120
org-checklist-export-function 'org-export-as-ascii
org-completion-use-ido t
org-after-todo-state-change-hook '(org-clock-out-if-current org-checklist)
org-agenda-todo-ignore-scheduled t
org-todo-state-tags-triggers '((todo ("NOTE")) ("" ("NOTE" . t)))
org-log-redeadline 'time
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tab-first-hook '(org-hide-block-toggle-maybe)
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-confirm-shell-link-function 'yes-or-no-p
org-todo-keywords '((sequence "TODO(t)" "STARTED(s)" "|" "DONE(D@)")
(sequence "MAYBE(m)" "WAITING(w@/!)" "|" "CANCELLED(C@)")
(sequence "APPT(a)" "DEFERRED(d@/!)" "|" "DONE(D@)" "CANCELLED(C@)"))
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-directory "~/Org"
org-log-reschedule 'time
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-publish-project-alist '(("private-dynamic" :base-directory "~/Org/www" :base-extension "org" :publishing-directory
"~/www/private" :publishing-function (org-publish-org-to-html) :recursive t :author
"David Maus" :email "maus.david@gmail.com")
("private-static" :base-directory "~/Org/www" :base-extension "css" :publishing-directory
"~/www/private" :publishing-function org-publish-attachment :recursive t)
("private" :components ("private-dynamic" "private-static")))
org-mode-hook '(#[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5])
org-refile-targets '((org-agenda-files :maxlevel . 3))
org-confirm-elisp-link-function 'yes-or-no-p
org-refile-use-outline-path 'file
org-log-into-drawer "LOGBOOK"
org-agenda-todo-ignore-with-date t
org-enforce-todo-dependencies t
org-occur-hook '(org-first-headline-recenter)
org-from-is-user-regexp "\\<David Maus\\>"
org-tags-column -120
org-remember-templates '(("todo" 116
"* TODO %^{Description} %^G\n :PROPERTIES:\n :Created: %U\n :Ref: %a\n :END:\n\n %?"
"refile.org" bottom nil)
("appt" 97
"* APPT %^{Description} %^G\n %^T\n :PROPERTIES:\n :Created: %U\n :Ref: %a\n :END:\n\n %?"
"refile.org" bottom nil)
("note" 110
"* %^{Description} :NOTE:%^G\n :PROPERTIES:\n :Created: %U\n :Ref: %a\n :END:\n\n %?"
"refile.org" bottom nil)
("mail" 109
"* TODO %^{Action} ([[wl:%5B%:message-id%5D~/.elmo/namazu#%:message-id][Link]]) %:subject :MAIL:%^G\n :PROPERTIES:\n :Created: %U\n :Ref: [[wl:%5B%:message-id%5D~/.elmo/namazu#%:message-id][%:message-id]]\n :From: %:from <%:fromaddress>\n :To: %:toname <%:toaddress>\n :Subject: %:subject\n :END:\n\n %?"
"refile.org" bottom (wl-summary-mode))
)
)
[-- Attachment #2: 0001-org-wl-get-from-field-regardless-of-wl-use-petname.patch --]
[-- Type: application/octet-stream, Size: 900 bytes --]
From 0701403d76a22ee9e22249a7e0202019444717d9 Mon Sep 17 00:00:00 2001
From: David Maus <maus.david@gmail.com>
Date: Sat, 14 Nov 2009 12:37:47 +0100
Subject: [PATCH] org-wl: get from field regardless of wl-use-petname
---
lisp/org-wl.el | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/lisp/org-wl.el b/lisp/org-wl.el
index c329743..3f3f794 100644
--- a/lisp/org-wl.el
+++ b/lisp/org-wl.el
@@ -91,7 +91,11 @@
wl-summary-buffer-elmo-folder msgnum)
(elmo-msgdb-overview-get-entity
msgnum (wl-summary-buffer-msgdb))))
- (from (wl-summary-line-from))
+ (from (let ((from-field (elmo-message-entity-field wl-message-entity
+ 'from)))
+ (if (listp from-field)
+ (car from-field)
+ from-field)))
(to (let ((to-field (elmo-message-entity-field wl-message-entity
'to)))
(if (listp to-field)
--
1.6.5
[-- Attachment #3: Type: text/plain, Size: 116 bytes --]
--
OpenPGP... 0x316F4BE4670716FD
Jabber.... dmjena@jabber.org
Email..... maus.david@gmail.com
ICQ....... 241051416
[-- Attachment #4: Type: text/plain, Size: 204 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next reply other threads:[~2009-11-14 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 11:43 David Maus [this message]
2009-11-15 13:27 ` Bug: org-wl: from property not set as expected [6.33] Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpj5jpr3.wl%maus.david@gmail.com \
--to=maus.david@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).