From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Bug: org-wl: from property not set as expected [6.33] Date: Sat, 14 Nov 2009 12:43:28 +0100 Message-ID: <87bpj5jpr3.wl%maus.david@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Sat_Nov_14_12:43:28_2009-1" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9H2b-0003vz-2p for emacs-orgmode@gnu.org; Sat, 14 Nov 2009 06:43:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9H2Z-0003vn-HX for emacs-orgmode@gnu.org; Sat, 14 Nov 2009 06:43:39 -0500 Received: from [199.232.76.173] (port=34253 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9H2Z-0003vh-BD for emacs-orgmode@gnu.org; Sat, 14 Nov 2009 06:43:39 -0500 Received: from fg-out-1718.google.com ([72.14.220.153]:10801) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9H2Y-0001VT-RB for emacs-orgmode@gnu.org; Sat, 14 Nov 2009 06:43:39 -0500 Received: by fg-out-1718.google.com with SMTP id e21so590065fga.12 for ; Sat, 14 Nov 2009 03:43:37 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --Multipart_Sat_Nov_14_12:43:28_2009-1 Content-Type: text/plain; charset=US-ASCII Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See http://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org-mode mailing list. ------------------------------------------------------------------------ When storing a link to a Wanderlust message the link's :from property is not set to the full address field (i.e. Name ) if the Wanderlust customization variable `wl-use-petname' is set to 't, what is it's default value. This causes unexpected behavior when `org-store-link' is called for a remember template as the template's :fromname and :fromaddress properties are not set correctly: %:fromname is empty and :fromaddress contains the senders name and not the address. This misbehaviour is caused because `org-wl-store-link' calls `wl-summary-line-from' which respects `wl-use-petname' and returns the senders name only if this variable is set to 't. Attached patch changes this issue by simply make `org-wl-store-link' use the same code to get the from field as it does for the to field. Emacs : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3) of 2009-10-23 on elegiac, modified by Debian Package: Org-mode version 6.33 current state: ============== (setq org-clock-in-switch-to-state "STARTED" org-todo-keyword-faces '(("TODO" :foreground "red" :weight bold) ("STARTED" :foreground "orange red" :weight bold) ("DONE" :foreground "light green") ("MAYBE" :foreground "tomato") ("WAITING" :foreground "tan2" :weight bold) ("CANCELLED" :foreground "firebrick") ("APPT" :foreground "DeepSkyBlue1" :weight bold) ("DEFERRED" :foreground "light slate gray")) org-agenda-custom-commands '(("r" "Refile New Notes and Tasks" tags "LEVEL=1+REFILE" ((org-agenda-todo-ignore-with-date nil))) ("s" "Started Tasks" todo "STARTED" ((org-agenda-todo-ignore-scheduled nil) (org-agenda-todo-ignore-deadlines nil) (org-agenda-todo-ignore-with-date nil)) ) ) org-agenda-files '("/home/david/Org/pg.org" "/home/david/Org/work.org" "/home/david/Org/tec.org" "/home/david/Org/priv.org" "/home/david/Org/refile.org") org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent) org-agenda-tags-column -120 org-checklist-export-function 'org-export-as-ascii org-completion-use-ido t org-after-todo-state-change-hook '(org-clock-out-if-current org-checklist) org-agenda-todo-ignore-scheduled t org-todo-state-tags-triggers '((todo ("NOTE")) ("" ("NOTE" . t))) org-log-redeadline 'time org-export-preprocess-hook '(org-export-blocks-preprocess) org-tab-first-hook '(org-hide-block-toggle-maybe) org-src-mode-hook '(org-src-mode-configure-edit-buffer) org-confirm-shell-link-function 'yes-or-no-p org-todo-keywords '((sequence "TODO(t)" "STARTED(s)" "|" "DONE(D@)") (sequence "MAYBE(m)" "WAITING(w@/!)" "|" "CANCELLED(C@)") (sequence "APPT(a)" "DEFERRED(d@/!)" "|" "DONE(D@)" "CANCELLED(C@)")) org-agenda-before-write-hook '(org-agenda-add-entry-text) org-directory "~/Org" org-log-reschedule 'time org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-publish-project-alist '(("private-dynamic" :base-directory "~/Org/www" :base-extension "org" :publishing-directory "~/www/private" :publishing-function (org-publish-org-to-html) :recursive t :author "David Maus" :email "maus.david@gmail.com") ("private-static" :base-directory "~/Org/www" :base-extension "css" :publishing-directory "~/www/private" :publishing-function org-publish-attachment :recursive t) ("private" :components ("private-dynamic" "private-static"))) org-mode-hook '(#[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5]) org-refile-targets '((org-agenda-files :maxlevel . 3)) org-confirm-elisp-link-function 'yes-or-no-p org-refile-use-outline-path 'file org-log-into-drawer "LOGBOOK" org-agenda-todo-ignore-with-date t org-enforce-todo-dependencies t org-occur-hook '(org-first-headline-recenter) org-from-is-user-regexp "\\" org-tags-column -120 org-remember-templates '(("todo" 116 "* TODO %^{Description} %^G\n :PROPERTIES:\n :Created: %U\n :Ref: %a\n :END:\n\n %?" "refile.org" bottom nil) ("appt" 97 "* APPT %^{Description} %^G\n %^T\n :PROPERTIES:\n :Created: %U\n :Ref: %a\n :END:\n\n %?" "refile.org" bottom nil) ("note" 110 "* %^{Description} :NOTE:%^G\n :PROPERTIES:\n :Created: %U\n :Ref: %a\n :END:\n\n %?" "refile.org" bottom nil) ("mail" 109 "* TODO %^{Action} ([[wl:%5B%:message-id%5D~/.elmo/namazu#%:message-id][Link]]) %:subject :MAIL:%^G\n :PROPERTIES:\n :Created: %U\n :Ref: [[wl:%5B%:message-id%5D~/.elmo/namazu#%:message-id][%:message-id]]\n :From: %:from <%:fromaddress>\n :To: %:toname <%:toaddress>\n :Subject: %:subject\n :END:\n\n %?" "refile.org" bottom (wl-summary-mode)) ) ) --Multipart_Sat_Nov_14_12:43:28_2009-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="0001-org-wl-get-from-field-regardless-of-wl-use-petname.patch" Content-Transfer-Encoding: base64 RnJvbSAwNzAxNDAzZDc2YTIyZWU5ZTIyMjQ5YTdlMDIwMjAxOTQ0NDcxN2Q5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxtYXVzLmRhdmlkQGdtYWlsLmNvbT4KRGF0 ZTogU2F0LCAxNCBOb3YgMjAwOSAxMjozNzo0NyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIG9yZy13 bDogZ2V0IGZyb20gZmllbGQgcmVnYXJkbGVzcyBvZiB3bC11c2UtcGV0bmFtZQoKLS0tCiBsaXNw L29yZy13bC5lbCB8ICAgIDYgKysrKystCiAxIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy13bC5lbCBiL2xpc3Avb3Jn LXdsLmVsCmluZGV4IGMzMjk3NDMuLjNmM2Y3OTQgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLXdsLmVs CisrKyBiL2xpc3Avb3JnLXdsLmVsCkBAIC05MSw3ICs5MSwxMSBAQAogCQkgd2wtc3VtbWFyeS1i dWZmZXItZWxtby1mb2xkZXIgbXNnbnVtKQogCSAgICAgIChlbG1vLW1zZ2RiLW92ZXJ2aWV3LWdl dC1lbnRpdHkKIAkgICAgICAgbXNnbnVtICh3bC1zdW1tYXJ5LWJ1ZmZlci1tc2dkYikpKSkKLQkg ICAoZnJvbSAod2wtc3VtbWFyeS1saW5lLWZyb20pKQorCSAgIChmcm9tIChsZXQgKChmcm9tLWZp ZWxkIChlbG1vLW1lc3NhZ2UtZW50aXR5LWZpZWxkIHdsLW1lc3NhZ2UtZW50aXR5CisJCQkJCQkJ ICAgICAgJ2Zyb20pKSkKKwkJICAgKGlmIChsaXN0cCBmcm9tLWZpZWxkKQorCQkgICAgICAgKGNh ciBmcm9tLWZpZWxkKQorCQkgICAgIGZyb20tZmllbGQpKSkKIAkgICAodG8gKGxldCAoKHRvLWZp ZWxkIChlbG1vLW1lc3NhZ2UtZW50aXR5LWZpZWxkIHdsLW1lc3NhZ2UtZW50aXR5CiAJCQkJCQkJ ICAndG8pKSkKIAkJIChpZiAobGlzdHAgdG8tZmllbGQpCi0tIAoxLjYuNQoK --Multipart_Sat_Nov_14_12:43:28_2009-1 Content-Type: text/plain; charset=US-ASCII -- OpenPGP... 0x316F4BE4670716FD Jabber.... dmjena@jabber.org Email..... maus.david@gmail.com ICQ....... 241051416 --Multipart_Sat_Nov_14_12:43:28_2009-1 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --Multipart_Sat_Nov_14_12:43:28_2009-1--