[PATCH] org.el: Fix bug from switch to lexical binding

[PATCH] org.el: Fix bug from switch to lexical binding

[Michael Strey]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]


Please check carefully before applying!  I do not understand what I have
done here but it worked for me without side effects.

-- 
Michael Strey
_
mailto:mstrey@strey.biz
http://www.strey.biz * https://twitter.com/michaelstrey


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From b76d6ef5975e1ba0b5ad4317246e1084d43ff446 Mon Sep 17 00:00:00 2001
From: Michael Strey <mstrey@strey.biz>
Date: Fri, 8 Apr 2016 14:03:30 +0200
Subject: [PATCH] org.el: Fix bug from switch to lexical binding

* lisp/org.el (org-check-dates-range): Fix a bug introduces with the
  switch to lexical binding in commit
  1f49e9fdfd8b527377b5592bd65ad3be6abb9e6a.

This change fixed the following bug:  C-c \ D leads to error message "Symbol's value as variable is void: start-date".

TINYCHANGE
---
 lisp/org.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 4f60c7f..b6d1c2d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17489,12 +17489,12 @@ both scheduled and deadline timestamps."
   (let ((case-fold-search nil)
 	(regexp (org-re-timestamp org-ts-type))
 	(callback
-	 `(lambda ()
+	 (lambda ()
 	    (let ((match (match-string 1)))
 	      (and
-	       ,(if (memq org-ts-type '(active inactive all))
-		    '(eq (org-element-type (org-element-context)) 'timestamp)
-		  '(org-at-planning-p))
+	       (if (memq org-ts-type '(active inactive all))
+		    (eq (org-element-type (org-element-context)) 'timestamp)
+		  (org-at-planning-p))
 	       (not (time-less-p
 		     (org-time-string-to-time match)
 		     (org-time-string-to-time start-date)))
-- 
2.7.3

Re: [PATCH] org.el: Fix bug from switch to lexical binding

[Nicolas Goaziou]

Hello,

Michael Strey <mstrey@strey.biz> writes:

> Please check carefully before applying!  I do not understand what I have
> done here but it worked for me without side effects.

Applied, with a minor change. Thank you.

Regards,

-- 
Nicolas Goaziou