unofficial mirror of emacs-orgmode@gnu.org
 help / color / mirror / Atom feed
* Emacs version for Org 9.4?
@ 2020-09-15  8:22 Jens Lechtenboerger
  2020-09-15  9:46 ` Jeremie Juste
  2020-09-16  3:39 ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Kyle Meyer
  0 siblings, 2 replies; 7+ messages in thread
From: Jens Lechtenboerger @ 2020-09-15  8:22 UTC (permalink / raw)
  To: emacs-orgmode

Hi there,

if I open an Org file on
“GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of
2017-09-12 on hullmann, modified by Debian”
I get this error (which I don’t know how to debug):

Eager macro-expansion failure: (wrong-type-argument listp :pcase--succeed)

Recipe:
touch empty.org
curl -L https://orgmode.org/elpa/org-plus-contrib-20200914.tar > org.tar
mkdir org && tar xf org.tar -C org --strip-components 1
rm -f org.tar
emacs -Q -L org
C-x C-f empty.org

In ORG-NEWS, I only found that “Emacs 24.4 or above is suggested.”
Did that change?

Best wishes
Jens


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Emacs version for Org 9.4?
  2020-09-15  8:22 Emacs version for Org 9.4? Jens Lechtenboerger
@ 2020-09-15  9:46 ` Jeremie Juste
  2020-09-15 10:57   ` Jens Lechtenboerger
  2020-09-16  3:39 ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Kyle Meyer
  1 sibling, 1 reply; 7+ messages in thread
From: Jeremie Juste @ 2020-09-15  9:46 UTC (permalink / raw)
  To: emacs-orgmode

Hello Jens,

I'm afraid I cannot test your issue. I don't have the ability to switch
emacs version yet.

What I can tell you is that org-9.4 is working fine on GNU Emacs 27.1,
and on Emacs 28.0.50.

Does anyone have problem on the official Debian 10 repo emacs 1:26.1+1-3.2+deb10u1?

Hope this helps,
Jeremie

- Org mode version 9.4 (release_9.4-9-g41a3c3 @
  /home/djj/src/org-mode/lisp/)
- GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-09-01

Jens Lechtenboerger <lechten@wi.uni-muenster.de> writes:

> Hi there,
>
> if I open an Org file on
> “GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of
> 2017-09-12 on hullmann, modified by Debian”
> I get this error (which I don’t know how to debug):
>
> Eager macro-expansion failure: (wrong-type-argument listp :pcase--succeed)
>
> Recipe:
> touch empty.org
> curl -L https://orgmode.org/elpa/org-plus-contrib-20200914.tar > org.tar
> mkdir org && tar xf org.tar -C org --strip-components 1
> rm -f org.tar
> emacs -Q -L org
> C-x C-f empty.org
>
> In ORG-NEWS, I only found that “Emacs 24.4 or above is suggested.”
> Did that change?
>
> Best wishes
> Jens


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Emacs version for Org 9.4?
  2020-09-15  9:46 ` Jeremie Juste
@ 2020-09-15 10:57   ` Jens Lechtenboerger
  0 siblings, 0 replies; 7+ messages in thread
From: Jens Lechtenboerger @ 2020-09-15 10:57 UTC (permalink / raw)
  To: Jeremie Juste; +Cc: emacs-orgmode

On 2020-09-15, Jeremie Juste wrote:

> Hello Jens,
>
> I'm afraid I cannot test your issue. I don't have the ability to switch
> emacs version yet.
>
> What I can tell you is that org-9.4 is working fine on GNU Emacs 27.1,
> and on Emacs 28.0.50.

Hello Jeremie,

thanks for your reply.  Yes, I’m aware that newer versions of Emacs
work.  I’m interested in the officially supported “lowest” version
of Emacs.  (When trying Org mode 9.4, I got a test failure with
org-re-reveal, for which I still promise compatibility with Emacs
24: https://gitlab.com/oer/org-re-reveal/-/pipelines/190002022)

Best wishes
Jens


^ permalink raw reply	[flat|nested] 7+ messages in thread

* pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
  2020-09-15  8:22 Emacs version for Org 9.4? Jens Lechtenboerger
  2020-09-15  9:46 ` Jeremie Juste
@ 2020-09-16  3:39 ` Kyle Meyer
  2020-09-16  5:40   ` Jens Lechtenboerger
  1 sibling, 1 reply; 7+ messages in thread
From: Kyle Meyer @ 2020-09-16  3:39 UTC (permalink / raw)
  To: emacs-orgmode

Jens Lechtenboerger writes:

> Hi there,
>
> if I open an Org file on
> “GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of
> 2017-09-12 on hullmann, modified by Debian”
> I get this error (which I don’t know how to debug):
>
> Eager macro-expansion failure: (wrong-type-argument listp :pcase--succeed)
[...]
> In ORG-NEWS, I only found that “Emacs 24.4 or above is suggested.”
> Did that change?

No, it didn't.

It is pretty tricky to debug, but the failure starts with 4a27b67fd
(org-element: Fix property drawers parsing, 2020-04-22).  As far as I
can see, the pattern introduced there is perfectly valid and should be
compatible with Emacs 24.  I'd _guess_ this is a pcase bug in Emacs 24,
particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
didn't make an effort to try to understand that commit.

Interestingly, the error goes away if I just swap the elements in the
pcase (and ...) pattern added by that commit.  Dunno, but if that clears
up the failure on your end as well, I don't see any reason to not make
that change.


diff --git a/lisp/org-element.el b/lisp/org-element.el
index a693cb68d..755de8661 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -4324,7 +4324,7 @@ (defsubst org-element--next-mode (mode type parent?)
   (if parent?
       (pcase type
 	(`headline 'section)
-	((and `section (guard (eq mode 'first-section))) 'top-comment)
+	((and (guard (eq mode 'first-section)) `section) 'top-comment)
 	(`inlinetask 'planning)
 	(`plain-list 'item)
 	(`property-drawer 'node-property)


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
  2020-09-16  3:39 ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Kyle Meyer
@ 2020-09-16  5:40   ` Jens Lechtenboerger
  2020-09-17  1:56     ` Kyle Meyer
  0 siblings, 1 reply; 7+ messages in thread
From: Jens Lechtenboerger @ 2020-09-16  5:40 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

On 2020-09-15, Kyle Meyer wrote:

> It is pretty tricky to debug, but the failure starts with 4a27b67fd
> (org-element: Fix property drawers parsing, 2020-04-22).  As far as I
> can see, the pattern introduced there is perfectly valid and should be
> compatible with Emacs 24.  I'd _guess_ this is a pcase bug in Emacs 24,
> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
> didn't make an effort to try to understand that commit.
>
> Interestingly, the error goes away if I just swap the elements in the
> pcase (and ...) pattern added by that commit.  Dunno, but if that clears
> up the failure on your end as well, I don't see any reason to not make
> that change.
>
>
> diff --git a/lisp/org-element.el b/lisp/org-element.el
> [...]

Yes, that fixes the problem over here.

Many thanks for debugging this, I’m deeply impressed.

Best wishes
Jens


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
  2020-09-16  5:40   ` Jens Lechtenboerger
@ 2020-09-17  1:56     ` Kyle Meyer
  2020-09-17 15:42       ` Kaushal Modi
  0 siblings, 1 reply; 7+ messages in thread
From: Kyle Meyer @ 2020-09-17  1:56 UTC (permalink / raw)
  To: Jens Lechtenboerger; +Cc: emacs-orgmode

Jens Lechtenboerger writes:

> On 2020-09-15, Kyle Meyer wrote:
>
>> It is pretty tricky to debug, but the failure starts with 4a27b67fd
>> (org-element: Fix property drawers parsing, 2020-04-22).  As far as I
>> can see, the pattern introduced there is perfectly valid and should be
>> compatible with Emacs 24.  I'd _guess_ this is a pcase bug in Emacs 24,
>> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
>> didn't make an effort to try to understand that commit.
>>
>> Interestingly, the error goes away if I just swap the elements in the
>> pcase (and ...) pattern added by that commit.  Dunno, but if that clears
>> up the failure on your end as well, I don't see any reason to not make
>> that change.
>>
>>
>> diff --git a/lisp/org-element.el b/lisp/org-element.el
>> [...]
>
> Yes, that fixes the problem over here.

Thanks for confirming.  Pushed (73c929e3b).


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
  2020-09-17  1:56     ` Kyle Meyer
@ 2020-09-17 15:42       ` Kaushal Modi
  0 siblings, 0 replies; 7+ messages in thread
From: Kaushal Modi @ 2020-09-17 15:42 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: Jens Lechtenboerger, emacs-org list

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

> On 2020-09-15, Kyle Meyer wrote:

> >
> >> It is pretty tricky to debug, but the failure starts with 4a27b67fd
> >> (org-element: Fix property drawers parsing, 2020-04-22).  As far as I
> >> can see, the pattern introduced there is perfectly valid and should be
> >> compatible with Emacs 24.  I'd _guess_ this is a pcase bug in Emacs 24,
> >> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
> >> didn't make an effort to try to understand that commit.
> >>
> >> Interestingly, the error goes away if I just swap the elements in the
> >> pcase (and ...) pattern added by that commit.  Dunno, but if that clears
> >> up the failure on your end as well, I don't see any reason to not make
> >> that change.
> >>
> >>
> >> diff --git a/lisp/org-element.el b/lisp/org-element.el
> >> [...]
> >
> > Yes, that fixes the problem over here.
>
> Thanks for confirming.  Pushed (73c929e3b).
>
>
I just stumbled on this as I was looking into why ox-hugo tests failed on
emacs 24.x (
https://travis-ci.org/github/kaushalmodi/ox-hugo/builds/728059027 ). This
should pass next week now. Thanks for your fix.

[-- Attachment #2: Type: text/html, Size: 1598 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-17 15:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15  8:22 Emacs version for Org 9.4? Jens Lechtenboerger
2020-09-15  9:46 ` Jeremie Juste
2020-09-15 10:57   ` Jens Lechtenboerger
2020-09-16  3:39 ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Kyle Meyer
2020-09-16  5:40   ` Jens Lechtenboerger
2020-09-17  1:56     ` Kyle Meyer
2020-09-17 15:42       ` Kaushal Modi

unofficial mirror of emacs-orgmode@gnu.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/orgmode/0 orgmode/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 orgmode orgmode/ https://yhetil.org/orgmode \
		emacs-orgmode@gnu.org
	public-inbox-index orgmode

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.orgmode
	nntp://news.gmane.io/gmane.emacs.orgmode


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git