From: stardiviner <numbchild@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: ob-clojure with tangling current broken
Date: Tue, 22 Jan 2019 15:52:00 +0800 [thread overview]
Message-ID: <8736plxh7j.fsf@gmail.com> (raw)
In-Reply-To: <CADjL5rV5ojdwNROr8uFy12y+NqFVRVhFyXuUXEkLvCCLp7McvQ@mail.gmail.com>
Frederick Giasson <fred@curbside.com> writes:
> Hi,
>
> I updated org-mode to latest dev version recently and I was wondering why I was
> seeing namespaces appended to each [clojure] code block I was tangling (which
> generates unusable tangled Clojure source files)
That's why I added a patch recently. Now Nicolas already applied my
patch. You should already seen it now.
>
> It turns out that the culprit is the following line:
> https://code.orgmode.org/bzg/org-mode/src/master/lisp/ob-clojure.el#L108
>
> I am wondering why is there such code injection in
> "org-babel-expand-body:clojure". It looks like to be related to the Clojure code
> block execution, but it also appears to be called from the tangling function.
> Clearly those two different use cases needs to be properly handled at the level
> of "ob-clojure.el"
>
Expanding clojure code is necessary to tangling, because when user have
noweb reference etc in source block, expanding here is necessary.
> I didn't follow all the changes to the "ob-clojure" mode in the last year or so,
> so please pardon my ignorance if the module is taking a different direction than
> I am used to. Is there a rational behind this behaviour or is there a new feature
> that I am not aware of which properly handle those two use cases?
>
Which part you don't understand, I might can answer your question,
because I did most of those changes in last year.
> Thanks,
>
> Take care,
>
> Fred
--
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
next prev parent reply other threads:[~2019-01-22 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 20:05 ob-clojure with tangling current broken Frederick Giasson
2019-01-22 7:52 ` stardiviner [this message]
2019-01-22 13:01 ` Frederick Giasson
2019-01-23 6:38 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736plxh7j.fsf@gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).