From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: ob-clojure with tangling current broken Date: Tue, 22 Jan 2019 15:52:00 +0800 Message-ID: <8736plxh7j.fsf@gmail.com> References: Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:38584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glqtX-0008Tw-Qq for emacs-orgmode@gnu.org; Tue, 22 Jan 2019 02:54:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glqtW-00027l-JL for emacs-orgmode@gnu.org; Tue, 22 Jan 2019 02:54:51 -0500 Received: from [122.236.19.222] (port=34024 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glqtT-0001mU-1e for emacs-orgmode@gnu.org; Tue, 22 Jan 2019 02:54:48 -0500 In-reply-to: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Frederick Giasson writes: > Hi, > > I updated org-mode to latest dev version recently and I was wondering why I was > seeing namespaces appended to each [clojure] code block I was tangling (which > generates unusable tangled Clojure source files) That's why I added a patch recently. Now Nicolas already applied my patch. You should already seen it now. > > It turns out that the culprit is the following line: > https://code.orgmode.org/bzg/org-mode/src/master/lisp/ob-clojure.el#L108 > > I am wondering why is there such code injection in > "org-babel-expand-body:clojure". It looks like to be related to the Clojure code > block execution, but it also appears to be called from the tangling function. > Clearly those two different use cases needs to be properly handled at the level > of "ob-clojure.el" > Expanding clojure code is necessary to tangling, because when user have noweb reference etc in source block, expanding here is necessary. > I didn't follow all the changes to the "ob-clojure" mode in the last year or so, > so please pardon my ignorance if the module is taking a different direction than > I am used to. Is there a rational behind this behaviour or is there a new feature > that I am not aware of which properly handle those two use cases? > Which part you don't understand, I might can answer your question, because I did most of those changes in last year. > Thanks, > > Take care, > > Fred -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3