emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] ob-core: Fix `org-babel-result-names'
@ 2023-10-16  9:53 hrdl
  2023-10-16 13:07 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: hrdl @ 2023-10-16  9:53 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: hrdl

* lisp/ob-core.el (org-babel-result-names): Do not change
  visibility of windows when called.

TINYCHANGE
---
 lisp/ob-core.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index a7c4f2cab..54dcf400e 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2015,12 +2015,12 @@ buffer or nil if no such result exists."
 
 (defun org-babel-result-names (&optional file)
   "Return the names of results in FILE or the current buffer."
-  (save-excursion
-    (when file (find-file file)) (goto-char (point-min))
-    (let ((case-fold-search t) names)
+  (with-current-buffer (if file (find-file-noselect file) (current-buffer))
+    (org-with-point-at 1
+      (let ((case-fold-search t) names)
       (while (re-search-forward org-babel-result-w-name-regexp nil t)
 	(setq names (cons (match-string-no-properties 9) names)))
-      names)))
+      names))))
 
 ;;;###autoload
 (defun org-babel-next-src-block (&optional arg)
-- 
2.42.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ob-core: Fix `org-babel-result-names'
  2023-10-16  9:53 [PATCH] ob-core: Fix `org-babel-result-names' hrdl
@ 2023-10-16 13:07 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2023-10-16 13:07 UTC (permalink / raw)
  To: hrdl; +Cc: emacs-orgmode

hrdl <git@hrdl.eu> writes:

> * lisp/ob-core.el (org-babel-result-names): Do not change
>   visibility of windows when called.

Thanks!
Applied, onto bugfix, amending the commit summary to

    org-babel-result-names: Do not alter window configuration

I also added you to the contributor list.
https://git.sr.ht/~bzg/worg/commit/112d4eaa

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-16 13:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16  9:53 [PATCH] ob-core: Fix `org-babel-result-names' hrdl
2023-10-16 13:07 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).