From: Marc Ihm <marc@ihm.name>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] contrib/lisp/ox-confluence.el: Export checkboxes; fix timestamps in headlines
Date: Wed, 03 May 2017 06:14:25 +0200 [thread overview]
Message-ID: <86r306zie6.fsf@ihm.name> (raw)
In-Reply-To: <87d1brycis.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 02 May 2017 08:54:19 +0200")
Hi,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
> This is a common mistake. Symbols in `cl-case' shouldn't be quoted. 'on
> is really (quote on), so you actually wrote
>
> (cl-case (org-element-property :checkbox item)
> ((quote on) "*{{(X)}}* ")
> ((quote off) "*{{( )}}* ")
> ((quote trans) "*{{(\\-)}}* "))
>
> which is not what you want:
>
> (cl-case 'quote ('a 1) ('quote 2) (t 3)) => 1
>
> This is why I prefer `pcase' over `cl-case'.
>
Interesting (and the docstring of `pcase') !
>> (format "h%s. %s%s\n%s" level todo-text text
>> (if (org-string-nw-p contents) contents ""))))
>>
>> @@ -181,7 +184,7 @@ a communication channel."
>> (defun org-confluence-timestamp (timestamp _contents _info)
>> "Transcode a TIMESTAMP object from Org to Confluence.
>> CONTENTS and INFO are ignored."
>> - (let ((translated (org-timestamp-translate timestamp)))
>> + (let ((translated (org-trim (org-timestamp-translate timestamp))))
>
> I'm not sure what this is supposed to fix. Does
> `org-timestamp-translate' return a string with leading or trailing
> blanks?
Yes, it did return trailing blanks for me.
> Anyway, I applied the patch in master branch, with the fix suggested
> above.
>
> Regards,
Thanx !
prev parent reply other threads:[~2017-05-03 4:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 15:29 [PATCH] contrib/lisp/ox-confluence.el: Export checkboxes; fix timestamps in headlines Marc Ihm
2017-05-02 6:54 ` Nicolas Goaziou
2017-05-03 4:14 ` Marc Ihm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r306zie6.fsf@ihm.name \
--to=marc@ihm.name \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).