From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Ihm <marc@ihm.name>
Subject: Re: [PATCH] contrib/lisp/ox-confluence.el: Export checkboxes; fix
 timestamps in headlines
Date: Wed, 03 May 2017 06:14:25 +0200
Message-ID: <86r306zie6.fsf@ihm.name>
References: <86r3087fys.fsf@ihm.name> <87d1brycis.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marc@ihm.name>) id 1d5lgZ-0002RB-Ru
	for emacs-orgmode@gnu.org; Wed, 03 May 2017 00:14:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marc@ihm.name>) id 1d5lgP-0005Pe-Pn
	for emacs-orgmode@gnu.org; Wed, 03 May 2017 00:14:38 -0400
Received: from smtp02.udag.de ([62.146.106.18]:56962)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <marc@ihm.name>) id 1d5lgP-0005NC-Go
	for emacs-orgmode@gnu.org; Wed, 03 May 2017 00:14:33 -0400
In-Reply-To: <87d1brycis.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Tue, 02 May 2017 08:54:19 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Hi, 

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>
> This is a common mistake. Symbols in `cl-case' shouldn't be quoted. 'on
> is really (quote on), so you actually wrote
>
>   (cl-case (org-element-property :checkbox item)
>     ((quote on) "*{{(X)}}* ")
>     ((quote off) "*{{( )}}* ")
>     ((quote trans) "*{{(\\-)}}* "))
>
> which is not what you want:
>
>   (cl-case 'quote ('a 1) ('quote 2) (t 3))    => 1
>
> This is why I prefer `pcase' over `cl-case'.
>

Interesting (and the docstring of `pcase') !

>>      (format "h%s. %s%s\n%s" level todo-text text
>>              (if (org-string-nw-p contents) contents ""))))
>>  
>> @@ -181,7 +184,7 @@ a communication channel."
>>  (defun org-confluence-timestamp (timestamp _contents _info)
>>    "Transcode a TIMESTAMP object from Org to Confluence.
>>  CONTENTS and INFO are ignored."
>> -  (let ((translated (org-timestamp-translate timestamp)))
>> +  (let ((translated (org-trim (org-timestamp-translate timestamp))))
>
> I'm not sure what this is supposed to fix. Does
> `org-timestamp-translate' return a string with leading or trailing
> blanks?

Yes, it did return trailing blanks for me.

> Anyway, I applied the patch in master branch, with the fix suggested
> above.
>
> Regards,

Thanx !