* Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
@ 2009-11-09 17:12 Bernt Hansen
2009-11-09 19:30 ` Bernt Hansen
0 siblings, 1 reply; 7+ messages in thread
From: Bernt Hansen @ 2009-11-09 17:12 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
Clocking out of a task moves point to the clock entry being closed.
This makes my workaround for clocking in a new task (just use a speed
key O to clock out and I to clock in) fail since we jump away from the
task that I want to clock in.
Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
of 2008-11-09 on raven, modified by Debian
Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
current state:
==============
(setq
org-export-html-final-hook '(org-inlinetask-remove-terminator)
org-log-done 'time
org-remember-default-headline "Tasks"
org-clock-in-switch-to-state "STARTED"
org-todo-keyword-faces '(("TODO" :foreground "red" :weight bold)
("STARTED" :foreground "blue" :weight bold)
("DONE" :foreground "forest green" :weight bold)
("WAITING" :foreground "orange" :weight bold)
("SOMEDAY" :foreground "magenta" :weight bold)
("CANCELLED" :foreground "forest green" :weight bold)
("QUOTE" :foreground "red" :weight bold)
("QUOTED" :foreground "magenta" :weight bold)
("APPROVED" :foreground "forest green" :weight bold)
("EXPIRED" :foreground "forest green" :weight bold)
("REJECTED" :foreground "forest green" :weight bold)
("OPEN" :foreground "blue" :weight bold))
org-show-siblings nil
org-special-ctrl-a/e t
org-agenda-clockreport-parameter-plist '(:link nil :maxlevel 2)
org-default-priority 71
org-agenda-custom-commands '(("s" "Started Tasks" todo "STARTED"
((org-agenda-todo-ignore-scheduled nil)
(org-agenda-todo-ignore-deadlines nil)
(org-agenda-todo-ignore-with-date nil))
)
("w" "Tasks waiting on something" tags "WAITING/!"
((org-use-tag-inheritance nil)))
("r" "Refile New Notes and Tasks" tags "LEVEL=1+REFILE"
((org-agenda-todo-ignore-with-date nil)))
("N" "Notes" tags "NOTE" nil)
("n" "Next" tags "NEXT-WAITING-CANCELLED/!" nil)
("p" "Projects" tags-todo "LEVEL=2-NEXT-WAITING-CANCELLED/!-DONE" nil)
("A" "Tasks to be Archived" tags "LEVEL=2/DONE|CANCELLED" nil))
org-agenda-files '("~/git/bzflag/bzflag-website/TODO.org" "~/git/org/bzflag.org"
"~/git/org/git.org" "~/git/org/todo.org" "~/git/org/jobs.org"
"~/git/org/refile.org" "~/git/org/farm.org" "~/git/org/mark.org"
"~/git/org/org.org" "~/git/org/norang.org")
org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
org-agenda-tags-column -102
org-export-ascii-final-hook '(org-inlinetask-remove-terminator)
org-export-with-sub-superscripts nil
org-clock-into-drawer "CLOCK"
org-checklist-export-function 'org-export-as-ascii
org-completion-use-ido t
org-metaup-hook '(org-babel-load-in-session-maybe)
org-agenda-skip-timestamp-if-done t
org-after-todo-state-change-hook '(org-checklist org-clock-out-if-current)
org-clock-out-when-done nil
org-agenda-text-search-extra-files '(agenda-archives)
org-agenda-todo-ignore-scheduled t
org-clock-history-length 35
org-babel-interpreters '("ditaa" "python" "ruby" "R" "sh" "emacs-lisp")
org-show-hierarchy-above t
org-time-stamp-rounding-minutes '(1 15)
org-speed-commands-user '(("1" . delete-other-windows) ("2" . split-window-horizontally)
("3" . split-window-vertically))
org-todo-state-tags-triggers '(("CANCELLED" ("CANCELLED" . t)) ("WAITING" ("WAITING" . t) ("NEXT"))
("SOMEDAY" ("WAITING" . t)) (done ("NEXT") ("WAITING"))
("TODO" ("WAITING") ("CANCELLED") ("NEXT"))
("DONE" ("WAITING") ("CANCELLED") ("NEXT")))
org-special-ctrl-k t
org-remember-clock-out-on-exit nil
org-agenda-sorting-strategy '((agenda habit-down time-up priority-down effort-up category-up)
(todo priority-down) (tags priority-down))
org-deadline-warning-days 30
org-agenda-skip-scheduled-if-done t
org-stuck-projects '("LEVEL=2-REFILE-WAITING|LEVEL=1+REFILE/!-DONE-CANCELLED-OPEN" nil ("NEXT") "")
org-agenda-time-grid '(nil "----------------" (800 1000 1200 1400 1600 1800 2000))
org-clock-in-resume t
org-quote-string "FOOBAR"
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tags-exclude-from-inheritance '("crypt")
org-tab-first-hook '(org-hide-block-toggle-maybe)
outline-regexp "\\*+ "
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-finalize-agenda-hook '(bh/org-agenda-to-appt)
org-confirm-shell-link-function 'yes-or-no-p
org-table-export-default-format "orgtbl-to-csv"
org-clock-persist 'history
org-clock-sound "/usr/local/lib/alert1.wav"
org-todo-keywords '((sequence "TODO(t!)" "STARTED(s!)" "|" "DONE(d!/!)")
(sequence "WAITING(w@/!)" "SOMEDAY(S!)" "OPEN(O@)" "|" "CANCELLED(c@/!)")
(sequence "QUOTE(q!)" "QUOTED(Q!)" "|" "APPROVED(A@)" "EXPIRED(E@)"
"REJECTED(R@)")
)
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-default-notes-file "~/git/org/refile.org"
org-export-docbook-xslt-proc-command "xsltproc --output %s /usr/share/xml/docbook/stylesheet/nwalsh/fo/docbook.xsl %s"
org-insert-heading-hook '(bh/insert-inactive-timestamp)
org-tag-alist '((:startgroup) ("@errand" . 101) ("@office" . 111) ("@home" . 104) ("@farm" . 102)
(:endgroup) ("PHONE" . 112) ("QUOTE" . 113) ("NEXT" . 110) ("WAITING" . 119)
("HOME" . 72) ("FARM" . 70) ("ORG" . 79) ("JOBS" . 74) ("SAPPI" . 83)
("NORANG" . 78) ("crypt" . 101) ("inet" . 105) ("MARK" . 77) ("BZFLAG" . 66))
org-blank-before-new-entry '((heading) (plain-list-item))
org-habit-graph-column 50
org-export-html-inline-images t
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-export-latex-classes '(("myletter"
"% BEGIN My Letter Defaults\n\\documentclass[10pt,letterpaper]{letter}\n\\usepackage[letterpaper,includeheadfoot,top=0.5in,bottom=0.5in,left=0.75in,right=0.75in]{geometry}\n\\usepackage[utf8]{inputenc}\n\\usepackage[T1]{fontenc}\n\\usepackage{hyperref}\n\\usepackage{lastpage}\n\\usepackage{fancyhdr}\n\\pagestyle{fancy}\n\\renewcommand{\\footrulewidth}{0.5pt}\n\n% Default footer\n\\fancyfoot[C]{\\small Page \\thepage\\ of \\pageref{LastPage}}\n% END My Letter Defaults\n\n"
("\\section{%s}" . "\\section*{%s}")
("\\subsection{%s}" . "\\subsection*{%s}")
("\\subsubsection{%s}" . "\\subsubsection*{%s}")
("\\paragraph{%s}" . "\\paragraph*{%s}")
("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
("myarticle"
"% BEGIN My Article Defaults\n\\documentclass[10pt,letterpaper]{article}\n\\usepackage[letterpaper,includeheadfoot,top=0.5in,bottom=0.5in,left=0.75in,right=0.75in]{geometry}\n\\usepackage[utf8]{inputenc}\n\\usepackage[T1]{fontenc}\n\\usepackage{hyperref}\n\\usepackage{lastpage}\n\\usepackage{fancyhdr}\n\\pagestyle{fancy}\n\\renewcommand{\\headrulewidth}{1pt}\n\\renewcommand{\\footrulewidth}{0.5pt}\n\n% Default footer\n\\fancyfoot[L]{\\small \\jobname \\\\ \\today}\n\\fancyfoot[C]{\\small Page \\thepage\\ of \\pageref{LastPage}}\n\\fancyfoot[R]{\\small \\copyright \\the\\year\\ Norang Consulting Inc.}\n% END My Article Defaults\n\n"
("\\section{%s}" . "\\section*{%s}")
("\\subsection{%s}" . "\\subsection*{%s}")
("\\subsubsection{%s}" . "\\subsubsection*{%s}")
("\\paragraph{%s}" . "\\paragraph*{%s}")
("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
("article"
"\\documentclass[11pt,letterpaper]{article}\n\\usepackage[utf8]{inputenc}\n\\usepackage[T1]{fontenc}\n\\usepackage{graphicx}\n\\usepackage{hyperref}"
("\\section{%s}" . "\\section*{%s}")
("\\subsection{%s}" . "\\subsection*{%s}")
("\\subsubsection{%s}" . "\\subsubsection*{%s}")
("\\paragraph{%s}" . "\\paragraph*{%s}")
("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
("report"
"\\documentclass[11pt,letterpaper]{report}\n\\usepackage[utf8]{inputenc}\n\\usepackage[T1]{fontenc}\n\\usepackage{graphicx}\n\\usepackage{hyperref}"
("\\part{%s}" . "\\part*{%s}") ("\\chapter{%s}" . "\\chapter*{%s}")
("\\section{%s}" . "\\section*{%s}")
("\\subsection{%s}" . "\\subsection*{%s}")
("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
("book"
"\\documentclass[11pt,letterpaper]{book}\n\\usepackage[utf8]{inputenc}\n\\usepackage[T1]{fontenc}\n\\usepackage{graphicx}\n\\usepackage{hyperref}"
("\\part{%s}" . "\\part*{%s}") ("\\chapter{%s}" . "\\chapter*{%s}")
("\\section{%s}" . "\\section*{%s}")
("\\subsection{%s}" . "\\subsection*{%s}")
("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
)
org-publish-project-alist '(("norang-org" :base-directory "~/git/www.norang.ca"
:publishing-directory "/ssh:www-data@www:~/www.norang.ca/htdocs"
:recursive t :section_numbers nil :table-of-contents nil
:base-extension "org" :publishing-function org-publish-org-to-html
:style-include-default nil :section-numbers nil :table-of-contents nil
:style-include-default nil :style
"<link rel=\"stylesheet\" href=\"norang.css\" type=\"text/css\" />"
:author-info nil :creator-info nil)
("norang-extra" :base-directory "~/git/www.norang.ca/"
:publishing-directory "/ssh:www-data@www:~/www.norang.ca/htdocs"
:base-extension "css\\|pdf\\|png\\|jpg\\|gif" :publishing-function
org-publish-attachment :recursive t :author nil)
("norang" :components ("norang-org" "norang-extra"))
("doc-org" :base-directory "~/git/doc.norang.ca/" :publishing-directory
"/ssh:www-data@www:~/doc.norang.ca/htdocs" :recursive t
:section_numbers nil :table-of-contents nil :base-extension "org"
:publishing-function (org-publish-org-to-html org-publish-org-to-org)
:plain-source t :htmlized-source t :style-include-default nil :style
"<link rel=\"stylesheet\" href=\"/org.css\" type=\"text/css\" />"
:author-info nil :creator-info nil)
("doc-extra" :base-directory "~/git/doc.norang.ca/"
:publishing-directory "/ssh:www-data@www:~/doc.norang.ca/htdocs"
:base-extension "css\\|pdf\\|png\\|jpg\\|gif" :publishing-function
org-publish-attachment :recursive t :author nil)
("org" :base-directory "~/git/org/" :publishing-directory
"/ssh:www-data@www:~/org" :recursive t :section_numbers nil
:table-of-contents nil :base-extension "org" :publishing-function
org-publish-org-to-html :style-include-default nil :style
"<link rel=\"stylesheet\" href=\"/org.css\" type=\"text/css\" />"
:author-info nil :creator-info nil)
("doc-org-mode" :base-directory "~/git/org-mode-doc/"
:publishing-directory "/ssh:www-data@www:~/doc.norang.ca/htdocs"
:recursive t :section_numbers nil :table-of-contents nil
:base-extension "org" :publishing-function
(org-publish-org-to-html org-publish-org-to-org) :plain-source t
:htmlized-source t :style-include-default nil :style
"<link rel=\"stylesheet\" href=\"/org.css\" type=\"text/css\" />"
:author-info nil :creator-info nil)
("doc-org-mode-extra" :base-directory "~/git/org-mode-doc/"
:publishing-directory "/ssh:www-data@www:~/doc.norang.ca/htdocs"
:base-extension "css\\|pdf\\|png\\|jpg\\|gif" :publishing-function
org-publish-attachment :recursive t :author nil)
("doc" :components
("doc-org" "doc-extra" "doc-org-mode" "doc-org-mode-extra"))
)
org-agenda-tags-todo-honor-ignore-options t
org-use-speed-commands t
org-mode-hook '(org-clock-load
(lambda nil (make-variable-buffer-local (quote yas/trigger-key))
(org-set-local (quote yas/trigger-key) [tab])
(define-key yas/keymap [tab] (quote yas/next-field-group)) (flyspell-mode 1))
#[nil "\300\301\302\303\304$\207"
[add-hook before-save-hook org-encrypt-entries nil t] 5]
#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-show-block-all append local] 5]
)
org-clock-out-remove-zero-time-clocks t
org-cycle-include-plain-lists nil
org-font-lock-hook '(org-inlinetask-fontify)
org-agenda-ndays 1
org-global-properties '(("Effort_ALL" .
"0:10 0:30 1:00 2:00 4:00 6:00 8:00 12:00 16:00 24:00 40:00")
("STYLE_ALL" . "habit"))
org-refile-targets '((nil :maxlevel . 5) (org-agenda-files :maxlevel . 5))
org-ctrl-c-ctrl-c-hook '(org-babel-lob-execute-maybe org-babel-execute-src-block-maybe)
org-return-follows-link t
org-confirm-elisp-link-function 'yes-or-no-p
org-refile-use-outline-path 'file
org-fast-tag-selection-single-key 'expert
org-log-into-drawer t
org-agenda-mode-hook '((lambda nil (hl-line-mode 1)))
org-agenda-start-on-weekday nil
org-agenda-todo-ignore-with-date t
org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src org-babel-exp-inline-src-blocks))
org-enforce-todo-dependencies t
org-agenda-skip-deadline-if-done t
org-show-following-heading t
org-insert-heading-respect-content t
org-crypt-key "F0B66B40"
org-occur-hook '(org-first-headline-recenter)
org-from-is-user-regexp "\\<Bernt Hansen\\>"
org-yank-adjusted-subtrees t
org-drawers '("PROPERTIES" "LOGBOOK" "CLOCK")
org-agenda-log-mode-items '(clock)
org-treat-S-cursor-todo-selection-as-state-change nil
org-export-docbook-xsl-fo-proc-command "fop %s %s"
org-agenda-todo-ignore-deadlines t
org-modules '(org-bbdb org-bibtex org-crypt org-gnus org-id org-info org-jsinfo org-habit
org-inlinetask org-irc org-mew org-mhe org-protocol org-rmail org-vm org-wl org-w3m)
org-columns-default-format "%80ITEM(Task) %10Effort(Estimated Effort){:} %10CLOCKSUM"
org-agenda-auto-exclude-function 'bh/org-auto-exclude-function
org-remember-templates '(("todo" 116 "* TODO %?\n %U\n %a" nil bottom nil)
("note" 110
"* %? :NOTE:\n %U\n %a" nil
bottom nil)
("phone" 112
"* PHONE %:name - %:company - :PHONE:\n Contact Info: %a\n %U\n :CLOCK-IN:\n %?" nil bottom nil)
("Apply to Job" 106
"* TODO jobtask%? :NEXT:inet:\n :PROPERTIES:\n :Effort: 0:30\n :END:\n %U\n jobdetails" "~/git/org/jobs.org" "TODO Job Search" nil)
("appointment" 97 "* %?\n %U" "~/git/org/todo.org" "Appointments" nil)
("Search job site" 115
"* TODO Search job site%! :NEXT:inet:\n %U\n :PROPERTIES:\n :Effort: 0:10\n :END:\n %a " "~/git/org/jobs.org" "Search Jobs" nil)
("org-protocol" 119
"* TODO Review %c%! :NEXT:\n %U\n :PROPERTIES:\n :Effort: 0:10\n :END:" nil bottom nil)
)
org-export-preprocess-after-tree-selection-hook '(org-inlinetask-export-handler)
org-export-docbook-final-hook '(org-inlinetask-remove-terminator)
org-export-latex-final-hook '(org-inlinetask-remove-terminator)
org-lowest-priority 71
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-clock-idle-time 1
org-export-blocks '((src org-babel-exp-src-blocks nil) (comment org-export-blocks-format-comment t)
(ditaa org-export-blocks-format-ditaa nil)
(dot org-export-blocks-format-dot nil))
)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
2009-11-09 17:12 Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry Bernt Hansen
@ 2009-11-09 19:30 ` Bernt Hansen
2009-11-09 21:37 ` Carsten Dominik
0 siblings, 1 reply; 7+ messages in thread
From: Bernt Hansen @ 2009-11-09 19:30 UTC (permalink / raw)
To: emacs-orgmode
Bernt Hansen <bernt@norang.ca> writes:
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen. You don't know how to make a good report? See
>
> http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> Clocking out of a task moves point to the clock entry being closed.
> This makes my workaround for clocking in a new task (just use a speed
> key O to clock out and I to clock in) fail since we jump away from the
> task that I want to clock in.
>
> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
> of 2008-11-09 on raven, modified by Debian
> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
Reverting this commit seems to fix it
7c0a16e (Use with-current-buffer instead of save-excursion set-buffer where possible, 2009-11-05)
-Bernt
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
2009-11-09 19:30 ` Bernt Hansen
@ 2009-11-09 21:37 ` Carsten Dominik
2009-11-09 21:42 ` Bernt Hansen
2009-11-09 21:53 ` Bernt Hansen
0 siblings, 2 replies; 7+ messages in thread
From: Carsten Dominik @ 2009-11-09 21:37 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
Hi Bernt,
could I ask you to only revert that patch in org-clock.el and
see if that is enought to fix it?
- Carsten
On Nov 9, 2009, at 8:30 PM, Bernt Hansen wrote:
> Bernt Hansen <bernt@norang.ca> writes:
>
>> Remember to cover the basics, that is, what you expected to happen
>> and
>> what in fact did happen. You don't know how to make a good
>> report? See
>>
>> http://orgmode.org/manual/Feedback.html#Feedback
>>
>> Your bug report will be posted to the Org-mode mailing list.
>> ------------------------------------------------------------------------
>>
>> Clocking out of a task moves point to the clock entry being closed.
>> This makes my workaround for clocking in a new task (just use a speed
>> key O to clock out and I to clock in) fail since we jump away from
>> the
>> task that I want to clock in.
>>
>> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
>> of 2008-11-09 on raven, modified by Debian
>> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
>
> Reverting this commit seems to fix it
> 7c0a16e (Use with-current-buffer instead of save-excursion set-
> buffer where possible, 2009-11-05)
>
> -Bernt
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
2009-11-09 21:37 ` Carsten Dominik
@ 2009-11-09 21:42 ` Bernt Hansen
2009-11-09 21:53 ` Bernt Hansen
1 sibling, 0 replies; 7+ messages in thread
From: Bernt Hansen @ 2009-11-09 21:42 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Okay - I'll get back to you on that.
Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi Bernt,
>
> could I ask you to only revert that patch in org-clock.el and
> see if that is enought to fix it?
>
> - Carsten
>
>
> On Nov 9, 2009, at 8:30 PM, Bernt Hansen wrote:
>
>> Bernt Hansen <bernt@norang.ca> writes:
>>
>>> Remember to cover the basics, that is, what you expected to happen
>>> and
>>> what in fact did happen. You don't know how to make a good
>>> report? See
>>>
>>> http://orgmode.org/manual/Feedback.html#Feedback
>>>
>>> Your bug report will be posted to the Org-mode mailing list.
>>> ------------------------------------------------------------------------
>>>
>>> Clocking out of a task moves point to the clock entry being closed.
>>> This makes my workaround for clocking in a new task (just use a speed
>>> key O to clock out and I to clock in) fail since we jump away from
>>> the
>>> task that I want to clock in.
>>>
>>> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
>>> of 2008-11-09 on raven, modified by Debian
>>> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
>>
>> Reverting this commit seems to fix it
>> 7c0a16e (Use with-current-buffer instead of save-excursion set-
>> buffer where possible, 2009-11-05)
>>
>> -Bernt
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> - Carsten
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
2009-11-09 21:37 ` Carsten Dominik
2009-11-09 21:42 ` Bernt Hansen
@ 2009-11-09 21:53 ` Bernt Hansen
2009-11-09 21:55 ` Carsten Dominik
1 sibling, 1 reply; 7+ messages in thread
From: Bernt Hansen @ 2009-11-09 21:53 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Reverting just the org-clock.el patches seems to fix it too.
-Bernt
--8<---------------cut here---------------start------------->8---
commit 01b1eb143f027bc6cdf54d95bd15fc03f2e03208
Author: Bernt Hansen <bernt@norang.ca>
Date: Mon Nov 9 14:27:03 2009 -0500
Revert part of "Use with-current-buffer instead of save-excursion set-buffer where possible"
This reverts the clocking changes in commit 7c0a16e2566e1cc3bb3c9f6b7571efe21f323a3c.
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index fc1e977..29cdf83 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -1103,7 +1103,8 @@ If there is no running clock, throw an error, unless FAIL-QUIETLY is set."
(if (not (marker-buffer org-clock-marker))
(if fail-quietly (throw 'exit t) (error "No active clock")))
(let (ts te s h m remove)
- (with-current-buffer (marker-buffer org-clock-marker)
+ (save-excursion
+ (set-buffer (marker-buffer org-clock-marker))
(save-restriction
(widen)
(goto-char org-clock-marker)
@@ -1168,7 +1169,8 @@ If there is no running clock, throw an error, unless FAIL-QUIETLY is set."
(interactive)
(if (not (marker-buffer org-clock-marker))
(error "No active clock"))
- (with-current-buffer (marker-buffer org-clock-marker)
+ (save-excursion
+ (set-buffer (marker-buffer org-clock-marker))
(goto-char org-clock-marker)
(delete-region (1- (point-at-bol)) (point-at-eol))
;; Just in case, remove any empty LOGBOOK left over
--8<---------------cut here---------------end--------------->8---
Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi Bernt,
>
> could I ask you to only revert that patch in org-clock.el and
> see if that is enought to fix it?
>
> - Carsten
>
>
> On Nov 9, 2009, at 8:30 PM, Bernt Hansen wrote:
>
>> Bernt Hansen <bernt@norang.ca> writes:
>>
>>> Remember to cover the basics, that is, what you expected to happen
>>> and
>>> what in fact did happen. You don't know how to make a good
>>> report? See
>>>
>>> http://orgmode.org/manual/Feedback.html#Feedback
>>>
>>> Your bug report will be posted to the Org-mode mailing list.
>>> ------------------------------------------------------------------------
>>>
>>> Clocking out of a task moves point to the clock entry being closed.
>>> This makes my workaround for clocking in a new task (just use a speed
>>> key O to clock out and I to clock in) fail since we jump away from
>>> the
>>> task that I want to clock in.
>>>
>>> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
>>> of 2008-11-09 on raven, modified by Debian
>>> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
>>
>> Reverting this commit seems to fix it
>> 7c0a16e (Use with-current-buffer instead of save-excursion set-
>> buffer where possible, 2009-11-05)
>>
>> -Bernt
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> - Carsten
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
2009-11-09 21:53 ` Bernt Hansen
@ 2009-11-09 21:55 ` Carsten Dominik
2009-11-09 22:00 ` Bernt Hansen
0 siblings, 1 reply; 7+ messages in thread
From: Carsten Dominik @ 2009-11-09 21:55 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
Hmmm.
I do not understand why this makes a difference, but I will make these
changes. Thanks a lot.
This was on of the big-sweep changes that happen in Emacs all the
time, where someone thinks we should use this and that style.
This looked trivial, so I accepted the changes. Too early it seems.
- Carsten
On Nov 9, 2009, at 10:53 PM, Bernt Hansen wrote:
> Reverting just the org-clock.el patches seems to fix it too.
>
> -Bernt
>
> --8<---------------cut here---------------start------------->8---
> commit 01b1eb143f027bc6cdf54d95bd15fc03f2e03208
> Author: Bernt Hansen <bernt@norang.ca>
> Date: Mon Nov 9 14:27:03 2009 -0500
>
> Revert part of "Use with-current-buffer instead of save-excursion
> set-buffer where possible"
>
> This reverts the clocking changes in commit
> 7c0a16e2566e1cc3bb3c9f6b7571efe21f323a3c.
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index fc1e977..29cdf83 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -1103,7 +1103,8 @@ If there is no running clock, throw an error,
> unless FAIL-QUIETLY is set."
> (if (not (marker-buffer org-clock-marker))
> (if fail-quietly (throw 'exit t) (error "No active clock")))
> (let (ts te s h m remove)
> - (with-current-buffer (marker-buffer org-clock-marker)
> + (save-excursion
> + (set-buffer (marker-buffer org-clock-marker))
> (save-restriction
> (widen)
> (goto-char org-clock-marker)
> @@ -1168,7 +1169,8 @@ If there is no running clock, throw an error,
> unless FAIL-QUIETLY is set."
> (interactive)
> (if (not (marker-buffer org-clock-marker))
> (error "No active clock"))
> - (with-current-buffer (marker-buffer org-clock-marker)
> + (save-excursion
> + (set-buffer (marker-buffer org-clock-marker))
> (goto-char org-clock-marker)
> (delete-region (1- (point-at-bol)) (point-at-eol))
> ;; Just in case, remove any empty LOGBOOK left over
> --8<---------------cut here---------------end--------------->8---
>
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Hi Bernt,
>>
>> could I ask you to only revert that patch in org-clock.el and
>> see if that is enought to fix it?
>>
>> - Carsten
>>
>>
>> On Nov 9, 2009, at 8:30 PM, Bernt Hansen wrote:
>>
>>> Bernt Hansen <bernt@norang.ca> writes:
>>>
>>>> Remember to cover the basics, that is, what you expected to happen
>>>> and
>>>> what in fact did happen. You don't know how to make a good
>>>> report? See
>>>>
>>>> http://orgmode.org/manual/Feedback.html#Feedback
>>>>
>>>> Your bug report will be posted to the Org-mode mailing list.
>>>> ------------------------------------------------------------------------
>>>>
>>>> Clocking out of a task moves point to the clock entry being closed.
>>>> This makes my workaround for clocking in a new task (just use a
>>>> speed
>>>> key O to clock out and I to clock in) fail since we jump away from
>>>> the
>>>> task that I want to clock in.
>>>>
>>>> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
>>>> of 2008-11-09 on raven, modified by Debian
>>>> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
>>>
>>> Reverting this commit seems to fix it
>>> 7c0a16e (Use with-current-buffer instead of save-excursion set-
>>> buffer where possible, 2009-11-05)
>>>
>>> -Bernt
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>> - Carsten
>>
>>
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
2009-11-09 21:55 ` Carsten Dominik
@ 2009-11-09 22:00 ` Bernt Hansen
0 siblings, 0 replies; 7+ messages in thread
From: Bernt Hansen @ 2009-11-09 22:00 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
I think it's because in my case I have two tasks in the same file I'm
clocking in.
* STARTED first clocking task
...
* TODO second clocking task
and updating the first clocking task moves the point in the buffer on me
so I lose my place (at the second clocking task). So clocking in the
second task while the first is clocking just moves point to first task,
clocks it out, then clocks it in again (since the point moved)
Does that make sense?
-Bernt
Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hmmm.
>
> I do not understand why this makes a difference, but I will make these
> changes. Thanks a lot.
>
> This was on of the big-sweep changes that happen in Emacs all the
> time, where someone thinks we should use this and that style.
>
> This looked trivial, so I accepted the changes. Too early it seems.
>
> - Carsten
>
> On Nov 9, 2009, at 10:53 PM, Bernt Hansen wrote:
>
>> Reverting just the org-clock.el patches seems to fix it too.
>>
>> -Bernt
>>
>> --8<---------------cut here---------------start------------->8---
>> commit 01b1eb143f027bc6cdf54d95bd15fc03f2e03208
>> Author: Bernt Hansen <bernt@norang.ca>
>> Date: Mon Nov 9 14:27:03 2009 -0500
>>
>> Revert part of "Use with-current-buffer instead of save-excursion
>> set-buffer where possible"
>>
>> This reverts the clocking changes in commit
>> 7c0a16e2566e1cc3bb3c9f6b7571efe21f323a3c.
>>
>> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
>> index fc1e977..29cdf83 100644
>> --- a/lisp/org-clock.el
>> +++ b/lisp/org-clock.el
>> @@ -1103,7 +1103,8 @@ If there is no running clock, throw an error,
>> unless FAIL-QUIETLY is set."
>> (if (not (marker-buffer org-clock-marker))
>> (if fail-quietly (throw 'exit t) (error "No active clock")))
>> (let (ts te s h m remove)
>> - (with-current-buffer (marker-buffer org-clock-marker)
>> + (save-excursion
>> + (set-buffer (marker-buffer org-clock-marker))
>> (save-restriction
>> (widen)
>> (goto-char org-clock-marker)
>> @@ -1168,7 +1169,8 @@ If there is no running clock, throw an error,
>> unless FAIL-QUIETLY is set."
>> (interactive)
>> (if (not (marker-buffer org-clock-marker))
>> (error "No active clock"))
>> - (with-current-buffer (marker-buffer org-clock-marker)
>> + (save-excursion
>> + (set-buffer (marker-buffer org-clock-marker))
>> (goto-char org-clock-marker)
>> (delete-region (1- (point-at-bol)) (point-at-eol))
>> ;; Just in case, remove any empty LOGBOOK left over
>> --8<---------------cut here---------------end--------------->8---
>>
>>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>>> Hi Bernt,
>>>
>>> could I ask you to only revert that patch in org-clock.el and
>>> see if that is enought to fix it?
>>>
>>> - Carsten
>>>
>>>
>>> On Nov 9, 2009, at 8:30 PM, Bernt Hansen wrote:
>>>
>>>> Bernt Hansen <bernt@norang.ca> writes:
>>>>
>>>>> Remember to cover the basics, that is, what you expected to happen
>>>>> and
>>>>> what in fact did happen. You don't know how to make a good
>>>>> report? See
>>>>>
>>>>> http://orgmode.org/manual/Feedback.html#Feedback
>>>>>
>>>>> Your bug report will be posted to the Org-mode mailing list.
>>>>> ------------------------------------------------------------------------
>>>>>
>>>>> Clocking out of a task moves point to the clock entry being closed.
>>>>> This makes my workaround for clocking in a new task (just use a
>>>>> speed
>>>>> key O to clock out and I to clock in) fail since we jump away from
>>>>> the
>>>>> task that I want to clock in.
>>>>>
>>>>> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
>>>>> of 2008-11-09 on raven, modified by Debian
>>>>> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
>>>>
>>>> Reverting this commit seems to fix it
>>>> 7c0a16e (Use with-current-buffer instead of save-excursion set-
>>>> buffer where possible, 2009-11-05)
>>>>
>>>> -Bernt
>>>>
>>>>
>>>> _______________________________________________
>>>> Emacs-orgmode mailing list
>>>> Remember: use `Reply All' to send replies to the list.
>>>> Emacs-orgmode@gnu.org
>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>>
>>> - Carsten
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> - Carsten
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-11-09 22:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-09 17:12 Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry Bernt Hansen
2009-11-09 19:30 ` Bernt Hansen
2009-11-09 21:37 ` Carsten Dominik
2009-11-09 21:42 ` Bernt Hansen
2009-11-09 21:53 ` Bernt Hansen
2009-11-09 21:55 ` Carsten Dominik
2009-11-09 22:00 ` Bernt Hansen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).