emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Table (with timestamps) HTML export bug
@ 2008-11-03 15:41 Charles Sebold
  2008-11-03 16:16 ` Charles Sebold
  2008-11-03 20:10 ` Carsten Dominik
  0 siblings, 2 replies; 4+ messages in thread
From: Charles Sebold @ 2008-11-03 15:41 UTC (permalink / raw)
  To: emacs-orgmode

I noticed a bug that seems to have crept in over the weekend, but I
can't quite make out where it came from.

In a table like this:

------------------------------------------------------------------------
| Date             | Index1 | Index2 |
|------------------+--------+--------|
| <2008-11-01 Sat> |    100 |    150 |
| <2008-11-02 Sun> |    110 |    140 |
| <2008-11-03 Mon> |    120 |    145 |
------------------------------------------------------------------------

If you export to HTML, you'll see the span before the timestamps with
HTML entities for the < and > characters, rather than having them
converted back.  It's as if we're missing an org-html-expand or an
org-html-do-expand somewhere.
-- 
Charles Sebold                                     3rd of November, 2008
 GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) | Gnus v5.11 | org-mode 6.10c
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Table (with timestamps) HTML export bug
  2008-11-03 15:41 Table (with timestamps) HTML export bug Charles Sebold
@ 2008-11-03 16:16 ` Charles Sebold
  2008-11-03 16:37   ` Charles Sebold
  2008-11-03 20:10 ` Carsten Dominik
  1 sibling, 1 reply; 4+ messages in thread
From: Charles Sebold @ 2008-11-03 16:16 UTC (permalink / raw)
  To: emacs-orgmode

On 3 Nov 2008, Charles Sebold wrote:

> I noticed a bug that seems to have crept in over the weekend, but I
> can't quite make out where it came from.

It was somewhere in the last commit, but I can't quite wrap my head
around the changes enough to figure out how this would break it.

[15b4ae903879407efe33a9f26b6c7704f260bb6c] Process link descriptions in
HTML export like any content.

On another note, that "git bisect" thing is pretty cool.
-- 
Charles Sebold                                     3rd of November, 2008
 GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) | Gnus v5.11 | org-mode 6.10c
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Table (with timestamps) HTML export bug
  2008-11-03 16:16 ` Charles Sebold
@ 2008-11-03 16:37   ` Charles Sebold
  0 siblings, 0 replies; 4+ messages in thread
From: Charles Sebold @ 2008-11-03 16:37 UTC (permalink / raw)
  To: emacs-orgmode

On 3 Nov 2008, Charles Sebold wrote:

>> I noticed a bug that seems to have crept in over the weekend, but I
>> can't quite make out where it came from.
>
> It was somewhere in the last commit, but I can't quite wrap my head
> around the changes enough to figure out how this would break it.
>
> [15b4ae903879407efe33a9f26b6c7704f260bb6c] Process link descriptions
> in HTML export like any content.

I doubt this is right, but it works.  What does it takes to make this
right?

diff --git a/lisp/org-exp.el b/lisp/org-exp.el
index 453cd1f..b61f8a9 100644
--- a/lisp/org-exp.el
+++ b/lisp/org-exp.el
@@ -3964,7 +3964,9 @@ If there are links in the string, don't modify these."
   (setq s (org-html-protect s))
   (if org-export-html-expand
       (let ((start 0))
-	(while (string-match "@&lt;\\([^&]*\\)&gt;" s)
+        (while (string-match "@&lt;\\(.*?\\)&quot;\\(.*?\\)&gt;" s)
+          (setq s (replace-match "@&lt;\\1\"\\2&gt;" t nil s)))
+	(while (string-match "@&lt;\\(.*?\\)&gt;" s)
 	  (setq s (replace-match "<\\1>" t nil s)))))
   (if org-export-with-emphasize
       (setq s (org-export-html-convert-emphasize s)))

-- 
Charles Sebold                                     3rd of November, 2008
 GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) | Gnus v5.11 | org-mode 6.10c
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: Table (with timestamps) HTML export bug
  2008-11-03 15:41 Table (with timestamps) HTML export bug Charles Sebold
  2008-11-03 16:16 ` Charles Sebold
@ 2008-11-03 20:10 ` Carsten Dominik
  1 sibling, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2008-11-03 20:10 UTC (permalink / raw)
  To: Charles Sebold; +Cc: emacs-orgmode

Yes, I have taken part of this change back, causes too many issues.

Thanks.

- Carsten

On Nov 3, 2008, at 4:41 PM, Charles Sebold wrote:

> I noticed a bug that seems to have crept in over the weekend, but I
> can't quite make out where it came from.
>
> In a table like this:
>
> ------------------------------------------------------------------------
> | Date             | Index1 | Index2 |
> |------------------+--------+--------|
> | <2008-11-01 Sat> |    100 |    150 |
> | <2008-11-02 Sun> |    110 |    140 |
> | <2008-11-03 Mon> |    120 |    145 |
> ------------------------------------------------------------------------
>
> If you export to HTML, you'll see the span before the timestamps with
> HTML entities for the < and > characters, rather than having them
> converted back.  It's as if we're missing an org-html-expand or an
> org-html-do-expand somewhere.
> --  
> Charles Sebold                                     3rd of November,  
> 2008
> GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) | Gnus v5.11 | org-mode 6.10c
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-11-03 22:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-03 15:41 Table (with timestamps) HTML export bug Charles Sebold
2008-11-03 16:16 ` Charles Sebold
2008-11-03 16:37   ` Charles Sebold
2008-11-03 20:10 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).