* [PATCH] why is '-' not allowed in radio table name?
@ 2010-04-17 21:30 Dan Davison
2010-04-18 6:10 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Dan Davison @ 2010-04-17 21:30 UTC (permalink / raw)
To: emacs org-mode mailing list
I was using a radio table to convert an org table to texinfo, and got
stuck for a bit until looking at the code and seeing that the name used
for the radio table can not contain '-' (only letters, numbers and
underscore). Is there a reason for this restriction? An alternative
regexp is below (which also allows tabs as whitespace).
Dan
Modified lisp/org-table.el
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 5839203..1d463a0 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -3800,7 +3800,7 @@ a radio table."
(goto-char (org-table-begin))
(let (rtn)
(beginning-of-line 0)
- (while (looking-at "[ \t]*#\\+ORGTBL[: \t][ \t]*SEND +\\([a-zA-Z0-9_]+\\) +\\([^ \t\r\n]+\\)\\( +.*\\)?")
+ (while (looking-at "[ \t]*#\\+ORGTBL[: \t][ \t]*SEND[ \t]+\\([^ \t\r\n]+\\)[ \t]+\\([^ \t\r\n]+\\)\\([ \t]+.*\\)?")
(let ((name (org-no-properties (match-string 1)))
(transform (intern (match-string 2)))
(params (if (match-end 3)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] why is '-' not allowed in radio table name?
2010-04-17 21:30 [PATCH] why is '-' not allowed in radio table name? Dan Davison
@ 2010-04-18 6:10 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-04-18 6:10 UTC (permalink / raw)
To: Dan Davison; +Cc: emacs org-mode mailing list
Applied, thanks.
- Carsten
On Apr 17, 2010, at 11:30 PM, Dan Davison wrote:
> I was using a radio table to convert an org table to texinfo, and got
> stuck for a bit until looking at the code and seeing that the name
> used
> for the radio table can not contain '-' (only letters, numbers and
> underscore). Is there a reason for this restriction? An alternative
> regexp is below (which also allows tabs as whitespace).
>
> Dan
>
>
> Modified lisp/org-table.el
> diff --git a/lisp/org-table.el b/lisp/org-table.el
> index 5839203..1d463a0 100644
> --- a/lisp/org-table.el
> +++ b/lisp/org-table.el
> @@ -3800,7 +3800,7 @@ a radio table."
> (goto-char (org-table-begin))
> (let (rtn)
> (beginning-of-line 0)
> - (while (looking-at "[ \t]*#\\+ORGTBL[: \t][ \t]*SEND +\\([a-
> zA-Z0-9_]+\\) +\\([^ \t\r\n]+\\)\\( +.*\\)?")
> + (while (looking-at "[ \t]*#\\+ORGTBL[: \t][ \t]*SEND[ \t]+\\
> ([^ \t\r\n]+\\)[ \t]+\\([^ \t\r\n]+\\)\\([ \t]+.*\\)?")
> (let ((name (org-no-properties (match-string 1)))
> (transform (intern (match-string 2)))
> (params (if (match-end 3)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-18 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-17 21:30 [PATCH] why is '-' not allowed in radio table name? Dan Davison
2010-04-18 6:10 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).