* Bug: Inconsistent usage of org-capture-get [9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)]
@ 2019-01-03 16:00 xristos
2019-01-04 13:19 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: xristos @ 2019-01-03 16:00 UTC (permalink / raw)
To: emacs-orgmode
At some point, the optional argument LOCAL was added to org-capture-get:
(org-capture-get PROP &optional LOCAL)
"When LOCAL is set, use the local variable ‘org-capture-current-plist’,
this is necessary after initialization of the capture process,
to avoid conflicts with other active capture processes."
A lot of the org-capture-get calls in org-capture.el do not set LOCAL
and suffer from aforementioned conflicts. The calls inside function org-capture
are exempt from this, but the calls inside org-capture-finalize that do not
set LOCAL are obviously erroneous. There are more org-capture-get calls in
other functions that have to be reviewed.
Emacs : GNU Emacs 25.3.2 (x86_64-apple-darwin17.4.0, Carbon Version 158 AppKit 1561.2)
of 2018-02-19
Package: Org mode version 9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: Inconsistent usage of org-capture-get [9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)]
2019-01-03 16:00 Bug: Inconsistent usage of org-capture-get [9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)] xristos
@ 2019-01-04 13:19 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2019-01-04 13:19 UTC (permalink / raw)
To: xristos; +Cc: emacs-orgmode
Hello,
xristos <xristos@sdf.org> writes:
> At some point, the optional argument LOCAL was added to org-capture-get:
>
> (org-capture-get PROP &optional LOCAL)
>
> "When LOCAL is set, use the local variable ‘org-capture-current-plist’,
> this is necessary after initialization of the capture process,
> to avoid conflicts with other active capture processes."
>
> A lot of the org-capture-get calls in org-capture.el do not set LOCAL
> and suffer from aforementioned conflicts. The calls inside function org-capture
> are exempt from this, but the calls inside org-capture-finalize that do not
> set LOCAL are obviously erroneous. There are more org-capture-get calls in
> other functions that have to be reviewed.
Do you want to provide a patch for that?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-04 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 16:00 Bug: Inconsistent usage of org-capture-get [9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)] xristos
2019-01-04 13:19 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).