emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug with %^{Property}p in org-remember templates
@ 2009-11-02 14:58 Adam Spiers
  2009-11-03  5:44 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Spiers @ 2009-11-02 14:58 UTC (permalink / raw)
  To: org-mode mailing list

The code for handling %^{PROP}p in org-remember templates seems to
have a bug:

	     ((equal char "p")
              (edebug)
	      (let*
		  ((prop (org-substring-no-properties prompt))
		   (pall (concat prop "_ALL"))
		   (allowed
		    (with-current-buffer
			(get-buffer (file-name-nondirectory file))

Here get-buffer can return nil, in which case `org-remember' fails
with the error:

  Wrong type argument: stringp, nil

It seems to be assuming that the non-directory part of the filename
corresponds to the buffer name, but this is not guaranteed.  Perhaps I
noticed it because I am using uniquify.el ?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: bug with %^{Property}p in org-remember templates
  2009-11-02 14:58 bug with %^{Property}p in org-remember templates Adam Spiers
@ 2009-11-03  5:44 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2009-11-03  5:44 UTC (permalink / raw)
  To: Adam Spiers; +Cc: org-mode mailing list

Fixed, thanks.

- Carsten

On Nov 2, 2009, at 3:58 PM, Adam Spiers wrote:

> The code for handling %^{PROP}p in org-remember templates seems to
> have a bug:
>
> 	     ((equal char "p")
>              (edebug)
> 	      (let*
> 		  ((prop (org-substring-no-properties prompt))
> 		   (pall (concat prop "_ALL"))
> 		   (allowed
> 		    (with-current-buffer
> 			(get-buffer (file-name-nondirectory file))
>
> Here get-buffer can return nil, in which case `org-remember' fails
> with the error:
>
>  Wrong type argument: stringp, nil
>
> It seems to be assuming that the non-directory part of the filename
> corresponds to the buffer name, but this is not guaranteed.  Perhaps I
> noticed it because I am using uniquify.el ?
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-03  5:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-02 14:58 bug with %^{Property}p in org-remember templates Adam Spiers
2009-11-03  5:44 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).