* Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)]
@ 2019-02-17 20:55 Piet van Oostrum
2019-02-18 20:43 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Piet van Oostrum @ 2019-02-17 20:55 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
In org-mode 9.2.1, the menu item Org > Show/Hide > Show All is bound to org-show-all, but this function is nor=t interactive. Therefore the invocation of this menu item fails.
command-execute: Wrong type argument: commandp, org-show-all
Solution: add (interactive)
diff -u /Users/piet/.emacs.d/elpa/org-9.2.1/org.el.\~1\~ /Users/piet/.emacs.d/elpa/org-9.2.1/org.el
--- /Users/piet/.emacs.d/elpa/org-9.2.1/org.el.~1~ 2019-02-17 21:37:16.000000000 +0100
+++ /Users/piet/.emacs.d/elpa/org-9.2.1/org.el 2019-02-17 21:54:11.000000000 +0100
@@ -6935,6 +6935,7 @@
By default, the function expands headings, blocks and drawers.
When optional argument TYPE is a list of symbols among `blocks',
`drawers' and `headings', to only expand one specific type."
+ (interactive)
(dolist (type (or types '(blocks drawers headings)))
(org-flag-region (point-min) (point-max) nil
(pcase type
Emacs : GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 Version 10.10.5 (Build 14F2511))
of 2018-05-31
Package: Org mode version 9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)
current state:
==============
(setq
org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-calendar-to-agenda-key [99]
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
org-odt-format-headline-function 'org-odt-format-headline-default-function
org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
org-reveal-start-hook '(org-decrypt-entry)
org-modules '(org-w3m org-bbdb org-bibtex org-docview org-gnus org-info org-irc org-mhe org-rmail)
org-export-creator-string "Emacs 26.1 (Org mode 9.1.9)"
org-mime-library 'vm
org-mode-hook '(#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-show-all append local] 5]
#[0 "\301\211\x10\207" [imenu-create-index-function org-imenu-get-tree] 2]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-show-block-all append local] 5]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
org-archive-hook '(org-attach-archive-delete-maybe)
org-confirm-elisp-link-function 'yes-or-no-p
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-metaup-hook '(org-babel-load-in-session-maybe)
org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
org-agenda-deadline-faces '((1.0 . org-warning) (0.5 . org-upcoming-deadline) (0.0 . default))
org-babel-pre-tangle-hook '(save-buffer)
org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
org-html-creator-string "<a href=\"https://www.gnu.org/software/emacs/\">Emacs</a> 26.1 (<a href=\"https://orgmode.org\">Org</a> mode 9.1.9)"
org-ascii-format-drawer-function #[771 "\x01\207" [] 4 "\n\n(fn NAME CONTENTS WIDTH)"]
org-src-lang-modes '(("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa" . artist)
("asymptote" . asy) ("dot" . fundamental) ("sqlite" . sql)
("calc" . fundamental) ("C" . c) ("cpp" . c++) ("C++" . c++)
("screen" . shell-script) ("shell" . sh) ("bash" . sh))
org-latex-table-scientific-notation "%s\\,(%s)"
org-html-infojs-template "<script type=\"text/javascript\" src=\"%SCRIPT_PATH\">\n/**\n *\n * @source: %SCRIPT_PATH\n *\n * @licstart The following is the entire license notice for the\n * JavaScript code in %SCRIPT_PATH.\n *\n * Copyright (C) 2012-2018 Free Software Foundation, Inc.\n *\n *\n * The JavaScript code in this tag is free software: you can\n * redistribute it and/or modify it under the terms of the GNU\n * General Public License (GNU GPL) as published by the Free Software\n * Foundation, either version 3 of the License, or (at your option)\n * any later version. The code is distributed WITHOUT ANY WARRANTY;\n * without even the implied warranty of MERCHANTABILITY or FITNESS\n * FOR A PARTICULAR PURPOSE. See the GNU GPL for more details.\n *\n * As additional permission under GNU GPL version 3 section 7, you\n * may distribute non-source (e.g., minimized or compacted) forms of\n * that code without the copy of the GNU GPL normally required by\n * section 4, provided you include this license notice and a URL\n * through which recipients can access the Corresponding Source.\n *\n * @licend The above is the entire license notice\n * for the JavaScript code in %SCRIPT_PATH.\n *\n */\n</script>\n\n<script type=\"text/javascript\">\n\n/*\n@licstart The following is the entire license notice for the\nJavaScript code in this tag.\n\nCopyright (C) 2012-2018 Free Software Foundation, Inc.\n\nThe JavaScript code in this tag is free software: you can\nredistribute it and/or modify it under the terms of the GNU\nGeneral Public License (GNU GPL) as published by the Free Software\nFoundation, either version 3 of the License, or (at your option)\nany later version. The code is distributed WITHOUT ANY WARRANTY;\nwithout even the implied warranty of MERCHANTABILITY or FITNESS\nFOR A PARTICULAR PURPOSE. See the GNU GPL for more details.\n\nAs additional permission under GNU GPL version 3 section 7, you\nmay distribute non-source (e.g., minimized or compacted) forms of\nthat code without the copy of the GNU GPL normally required by\nsection 4, provided you include this license notice and a URL\nthrough which recipients can access the Corresponding Source.\n\n\n@licend The above is the entire license notice\nfor the JavaScript code in this tag.\n*/\n\n<!--/*--><![CDATA[/*><!--*/\n%MANAGER_OPTIONS\norg_html_manager.setup(); // activate after the parameters are set\n/*]]>*///-->\n</script>"
org-occur-hook '(org-first-headline-recenter)
org-ditaa-jar-path "/Applications/Emacs.app/Contents/Resources/lisp/contrib/scripts/ditaa.jar"
org-structure-template-alist '(("s" "#+BEGIN_SRC ?\n\n#+END_SRC")
("e" "#+BEGIN_EXAMPLE\n?\n#+END_EXAMPLE")
("q" "#+BEGIN_QUOTE\n?\n#+END_QUOTE")
("v" "#+BEGIN_VERSE\n?\n#+END_VERSE")
("V" "#+BEGIN_VERBATIM\n?\n#+END_VERBATIM")
("c" "#+BEGIN_CENTER\n?\n#+END_CENTER")
("C" "#+BEGIN_COMMENT\n?\n#+END_COMMENT")
("l" "#+BEGIN_EXPORT latex\n?\n#+END_EXPORT") ("L" "#+LaTeX: ")
("h" "#+BEGIN_EXPORT html\n?\n#+END_EXPORT") ("H" "#+HTML: ")
("a" "#+BEGIN_EXPORT ascii\n?\n#+END_EXPORT") ("A" "#+ASCII: ")
("i" "#+INDEX: ?") ("I" "#+INCLUDE: %file ?"))
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
org-confirm-shell-link-function 'yes-or-no-p
org-link-parameters '(("id" :follow org-id-open)
("rmail" :follow org-rmail-open :store org-rmail-store-link)
("mhe" :follow org-mhe-open :store org-mhe-store-link)
("irc" :follow org-irc-visit :store org-irc-store-link :export
org-irc-export)
("info" :follow org-info-open :export org-info-export :store
org-info-store-link)
("gnus" :follow org-gnus-open :store org-gnus-store-link)
("docview" :follow org-docview-open :export org-docview-export :store
org-docview-store-link)
("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
org-bbdb-complete-link :store org-bbdb-store-link)
("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
("ipynb" :follow ein:org-open :help-echo "Open ipython notebook." :store
ein:org-store-link)
("doi" :follow org--open-doi-link) ("elisp" :follow org--open-elisp-link)
("file" :complete org-file-complete-link)
("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path))))
("help" :follow org--open-help-link)
("http" :follow (lambda (path) (browse-url (concat "http:" path))))
("https" :follow (lambda (path) (browse-url (concat "https:" path))))
("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path))))
("news" :follow (lambda (path) (browse-url (concat "news:" path))))
("shell" :follow org--open-shell-link))
org-latex-format-headline-function 'org-latex-format-headline-default-function
org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
org-clocktable-defaults '(:maxlevel 2 :lang "en" :scope file :block nil :wstart 1 :mstart 1
:tstart nil :tend nil :step nil :stepskip0 nil :fileskip0 nil :tags nil
:emphasize nil :link nil :narrow 40! :indent t :formula nil :timestamp
nil :level nil :tcolumns nil :formatter nil)
org-html-format-headline-function 'org-html-format-headline-default-function
)
--
Piet van Oostrum <piet@vanoostrum.org>
WWW: http://piet.vanoostrum.org/
PGP key: [8DAE142BE17999C4]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)]
2019-02-17 20:55 Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)] Piet van Oostrum
@ 2019-02-18 20:43 ` Nicolas Goaziou
2019-02-18 22:29 ` Piet van Oostrum
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2019-02-18 20:43 UTC (permalink / raw)
To: Piet van Oostrum; +Cc: emacs-orgmode
Hello,
Piet van Oostrum <piet@vanoostrum.org> writes:
> In org-mode 9.2.1, the menu item Org > Show/Hide > Show All is bound
> to org-show-all, but this function is nor=t interactive. Therefore the
> invocation of this menu item fails.
>
> command-execute: Wrong type argument: commandp, org-show-all
>
> Solution: add (interactive)
I wrote a commit message and applied your patch. I also added TINYCHANGE
cookie since I don't know if you signed papers already.
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)]
2019-02-18 20:43 ` Nicolas Goaziou
@ 2019-02-18 22:29 ` Piet van Oostrum
0 siblings, 0 replies; 3+ messages in thread
From: Piet van Oostrum @ 2019-02-18 22:29 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
Nicolas Goaziou wrote:
> Hello,
>
> Piet van Oostrum <piet@vanoostrum.org> writes:
>
> > In org-mode 9.2.1, the menu item Org > Show/Hide > Show All is bound
> > to org-show-all, but this function is nor=t interactive. Therefore the
> > invocation of this menu item fails.
> >
> > command-execute: Wrong type argument: commandp, org-show-all
> >
> > Solution: add (interactive)
>
> I wrote a commit message and applied your patch. I also added TINYCHANGE
> cookie since I don't know if you signed papers already.
>
I signed papers for Emacs long long long time ago. Possibly with an older email address like piet@cs.uu.nl or piet@cs.ruu.nl.
But in this case the change is trivial, and there really is no other reasonable way to do it.
If I had thought about it I would not have given a patch :)
--
Piet van Oostrum <piet@vanoostrum.org>
WWW: http://piet.vanoostrum.org/
PGP key: [8DAE142BE17999C4]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-18 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-17 20:55 Bug: org-show-all is missing an (interactive) declaration [9.2.1 (9.2.1-elpa @ /Users/piet/.emacs.d/elpa/org-9.2.1/)] Piet van Oostrum
2019-02-18 20:43 ` Nicolas Goaziou
2019-02-18 22:29 ` Piet van Oostrum
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).